Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1734)

Unified Diff: android_webview/native/aw_settings.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_settings.cc
diff --git a/android_webview/native/aw_settings.cc b/android_webview/native/aw_settings.cc
index a5ae993bc71502b1c1baba606e3a3b09c0f2a18d..f708da6fd057f8fcb784924cfcf33ba7a38ee525 100644
--- a/android_webview/native/aw_settings.cc
+++ b/android_webview/native/aw_settings.cc
@@ -421,16 +421,17 @@ void AwSettings::PopulateWebPreferencesLocked(
}
static jlong Init(JNIEnv* env,
- jobject obj,
- jobject web_contents) {
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jobject>& web_contents) {
content::WebContents* contents = content::WebContents::FromJavaWebContents(
web_contents);
AwSettings* settings = new AwSettings(env, obj, contents);
return reinterpret_cast<intptr_t>(settings);
}
-static ScopedJavaLocalRef<jstring> GetDefaultUserAgent(JNIEnv* env,
- jclass clazz) {
+static ScopedJavaLocalRef<jstring> GetDefaultUserAgent(
+ JNIEnv* env,
+ const JavaParamRef<jclass>& clazz) {
return base::android::ConvertUTF8ToJavaString(env, GetUserAgent());
}
« no previous file with comments | « android_webview/native/aw_quota_manager_bridge_impl.cc ('k') | android_webview/native/aw_web_contents_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698