base/android/jni_generator/testJNIInitNativeNameOption.golden - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/jni_generator/testJNIInitNativeNameOption.golden

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/android/jni_generator/jni_generator.py ('K') | « base/android/jni_generator/testInnerClassNativesMultiple.golden ('k') | base/android/jni_generator/testJarJarRemapping.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/android/jni_generator/testJNIInitNativeNameOption.golden

diff --git a/base/android/jni_generator/testJNIInitNativeNameOption.golden b/base/android/jni_generator/testJNIInitNativeNameOption.golden

index 084f08d6eacd194315869de472be5742bfaade34..46a57ac5f55cb97012184c9c7ad550327e3524e4 100644

--- a/base/android/jni_generator/testJNIInitNativeNameOption.golden

+++ b/base/android/jni_generator/testJNIInitNativeNameOption.golden

@@ -33,7 +33,7 @@ static jint Java_org_chromium_example_jni_1generator_Test_nativeMethod(JNIEnv*

jint arg1) {

Test* native = reinterpret_cast<Test*>(nativeTest);

CHECK_NATIVE_PTR(env, jcaller, native, "Method", 0);

- return native->Method(env, jcaller, arg1);

+ return native->Method(env, JavaParamRef<jobject>(env, jcaller), arg1);

}

// Step 3: RegisterNatives.