Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: base/android/field_trial_list.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/android/cpu_features.cc ('k') | base/android/important_file_writer_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/field_trial_list.h" 5 #include "base/android/field_trial_list.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 8
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
11 #include "jni/FieldTrialList_jni.h" 11 #include "jni/FieldTrialList_jni.h"
12 12
13 using base::android::ConvertJavaStringToUTF8; 13 using base::android::ConvertJavaStringToUTF8;
14 using base::android::ConvertUTF8ToJavaString; 14 using base::android::ConvertUTF8ToJavaString;
15 15
16 static ScopedJavaLocalRef<jstring> FindFullName(JNIEnv* env, 16 static ScopedJavaLocalRef<jstring> FindFullName(
17 jclass clazz, 17 JNIEnv* env,
18 jstring jtrial_name) { 18 const JavaParamRef<jclass>& clazz,
19 const JavaParamRef<jstring>& jtrial_name) {
19 std::string trial_name(ConvertJavaStringToUTF8(env, jtrial_name)); 20 std::string trial_name(ConvertJavaStringToUTF8(env, jtrial_name));
20 return ConvertUTF8ToJavaString( 21 return ConvertUTF8ToJavaString(
21 env, base::FieldTrialList::FindFullName(trial_name)); 22 env, base::FieldTrialList::FindFullName(trial_name));
22 } 23 }
23 24
24 static jboolean TrialExists(JNIEnv* env, jclass clazz, jstring jtrial_name) { 25 static jboolean TrialExists(JNIEnv* env,
26 const JavaParamRef<jclass>& clazz,
27 const JavaParamRef<jstring>& jtrial_name) {
25 std::string trial_name(ConvertJavaStringToUTF8(env, jtrial_name)); 28 std::string trial_name(ConvertJavaStringToUTF8(env, jtrial_name));
26 return base::FieldTrialList::TrialExists(trial_name); 29 return base::FieldTrialList::TrialExists(trial_name);
27 } 30 }
28 31
29 namespace base { 32 namespace base {
30 namespace android { 33 namespace android {
31 34
32 bool RegisterFieldTrialList(JNIEnv* env) { 35 bool RegisterFieldTrialList(JNIEnv* env) {
33 return RegisterNativesImpl(env); 36 return RegisterNativesImpl(env);
34 } 37 }
35 38
36 } // namespace android 39 } // namespace android
37 } // namespace base 40 } // namespace base
OLDNEW
« no previous file with comments | « base/android/cpu_features.cc ('k') | base/android/important_file_writer_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698