cc/trees/layer_tree_host_unittest.cc - Issue 1312123005: cc: Fix use-after-free in test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 1312123005: cc: Fix use-after-free in test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host_unittest.cc

diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc

index b2c10efb0a08f0877521b59f85cb20e1c562bc93..0c90a5af6de7ccc8f3a2713e287b248c46eeb36f 100644

--- a/cc/trees/layer_tree_host_unittest.cc

+++ b/cc/trees/layer_tree_host_unittest.cc

@@ -2024,6 +2024,10 @@ class LayerTreeHostTestAbortedCommitDoesntStallSynchronousCompositor

}

void ScheduledActionInvalidateOutputSurface() override {

+ // Do not call ImplThreadTaskRunner after the test ended because of the

+ // possibility of use-after-free due to a race.

+ if (TestEnded())

+ return;

ImplThreadTaskRunner()->PostTask(

FROM_HERE,

base::Bind(

« no previous file with comments | « no previous file | tools/valgrind/gtest_exclude/cc_unittests.gtest-drmemory_win32.txt » ('j') | no next file with comments »