Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1312073003: Oilpan: fix build after r201639. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r201639. TBR=oilpan-reviews BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201650

Patch Set 1 #

Patch Set 2 : revert MatchedRule::RuleData change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/core/css/ElementRuleCollector.h View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
sof
5 years, 3 months ago (2015-09-02 14:47:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312073003/1
5 years, 3 months ago (2015-09-02 14:47:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201647
5 years, 3 months ago (2015-09-02 14:51:06 UTC) #4
sof
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1319623006/ by sigbjornf@opera.com. ...
5 years, 3 months ago (2015-09-02 14:55:43 UTC) #5
sof
relanding; the FIXME's reservations about RuleData wasn't taken care of elsewhere in this CL, so ...
5 years, 3 months ago (2015-09-02 16:04:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312073003/20001
5 years, 3 months ago (2015-09-02 16:04:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201650
5 years, 3 months ago (2015-09-02 16:08:54 UTC) #9
haraken
5 years, 3 months ago (2015-09-02 23:26:36 UTC) #10
Message was sent while issue was closed.
LGTM. Sorry about the breakage...

Powered by Google App Engine
This is Rietveld 408576698