Remove CONTENT_SETTINGS_NUM_TYPES (part 2)

chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
index a72928503a1fde8b0108c8703c9b5da175e02c1c..9b58dbcb25ba1cc0b83a0d9bf26a5bd52492f726 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
@@ -104,9 +104,8 @@ LocationBarViewMac::LocationBarViewMac(AutocompleteTextField* field,
           new ManagePasswordsDecoration(command_updater, this)),
       browser_(browser),
       weak_ptr_factory_(this) {
-  for (size_t i = 0; i < CONTENT_SETTINGS_NUM_TYPES; ++i) {
-    DCHECK_EQ(i, content_setting_decorations_.size());
-    ContentSettingsType type = static_cast<ContentSettingsType>(i);
+  for (ContentSettingsType type :

[msw, 2015/09/08 18:40:45]

nit: auto

[raymes, 2015/09/09 01:02:09]

Hmm I've had +bauerb@ ask me to do the exact opposite in cases like this. 

I read up on the style guide and skimmed the discussions around it:
http://chromium-cpp.appspot.com/ My feeling is that in this case it doesn't make
the code more readable to use auto (and potentially makes it less readable).
What do you think?

[msw, 2015/09/09 01:10:03]

I'd use auto in fairly obvious scenarios when it reduces lines of code, but it's
a nit, fine either way and subject to author/reviewer preferences.

+       ContentSettingBubbleModel::GetSupportedBubbleTypes()) {
     content_setting_decorations_.push_back(
         new ContentSettingDecoration(type, this, profile));
   }