chrome/browser/ui/content_settings/content_setting_bubble_model.h - Issue 1312053006: Remove CONTENT_SETTINGS_NUM_TYPES (part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.h

Issue 1312053006: Remove CONTENT_SETTINGS_NUM_TYPES (part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@website-settings-registry-4

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm ('K') | « chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm ('k') | chrome/browser/ui/content_settings/content_setting_bubble_model.cc » ('j') | chrome/browser/ui/content_settings/content_setting_bubble_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_bubble_model.h

diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.h b/chrome/browser/ui/content_settings/content_setting_bubble_model.h

index b6b9f7b19520efe47a9d66d3b5452667ae5f6ccf..8c0aba58a6e7df9c1ca30f32e2f1a05cc1df17ca 100644

--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.h

+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.h

@@ -97,6 +97,12 @@ class ContentSettingBubbleModel : public content::NotificationObserver {

DISALLOW_COPY_AND_ASSIGN(BubbleContent);

};

+ // Returns a vector of the Supported bubble types.

+ static const std::set<ContentSettingsType>& GetSupportedBubbleTypes();

+ // Returns true if the given ContentSettingsType has a bubble.

+ static bool HasBubble(ContentSettingsType type);

tapted 2015/09/03 06:36:38 HasBubbleForType? (HasBubble sounds too much like

raymes 2015/09/07 04:29:27 I removed this and changed the callers to just che

static ContentSettingBubbleModel* CreateContentSettingBubbleModel(

Delegate* delegate,

content::WebContents* web_contents,