Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1312053004: Require Sk4f::toBytes() clamps (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
mtklein, Noel Gordon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Require Sk4f::toBytes() clamps BUG=skia:4117 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;client.skia.android:Test-Android-GCC-Nexus9-CPU-Denver-Arm64-Release-Trybot Committed: https://skia.googlesource.com/skia/+/a508f3c62d726867ad9f722623fbf0ab5d06e440

Patch Set 1 #

Patch Set 2 : add test #

Total comments: 2

Patch Set 3 : 0.7f #

Patch Set 4 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M src/core/SkNx.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 chunk +0 lines, -1 line 0 comments Download
M tests/SkNxTest.cpp View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312053004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312053004/20001
5 years, 3 months ago (2015-09-01 12:25:00 UTC) #2
mtklein_C
5 years, 3 months ago (2015-09-01 12:30:41 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-01 12:38:14 UTC) #6
Noel Gordon
LGTM. https://codereview.chromium.org/1312053004/diff/20001/tests/SkNxTest.cpp File tests/SkNxTest.cpp (right): https://codereview.chromium.org/1312053004/diff/20001/tests/SkNxTest.cpp#newcode218 tests/SkNxTest.cpp:218: REPORTER_ASSERT(r, bytes[3] == 255); Thanks for the clamp ...
5 years, 3 months ago (2015-09-01 12:58:31 UTC) #7
mtklein_C
https://codereview.chromium.org/1312053004/diff/20001/tests/SkNxTest.cpp File tests/SkNxTest.cpp (right): https://codereview.chromium.org/1312053004/diff/20001/tests/SkNxTest.cpp#newcode218 tests/SkNxTest.cpp:218: REPORTER_ASSERT(r, bytes[3] == 255); On 2015/09/01 12:58:31, noel gordon ...
5 years, 3 months ago (2015-09-01 13:01:15 UTC) #8
mtklein
lgtm
5 years, 3 months ago (2015-09-01 13:01:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312053004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312053004/60001
5 years, 3 months ago (2015-09-01 13:02:01 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 13:29:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/a508f3c62d726867ad9f722623fbf0ab5d06e440

Powered by Google App Engine
This is Rietveld 408576698