Devtools UI: Upgrade breadcrumbs to material design UI

Devtools UI: Upgrade breadcrumbs to material design UI

BUG=527681
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201844

[samli, 2015-09-04 22:15:25]

samli@chromium.org changed reviewers:
+ pfeldman@chromium.org

[samli, 2015-09-04 22:15:25]

Screenshot: http://i.imgur.com/OR9ejaJ.png

[pfeldman, 2015-09-05 00:24:05]

lgtm

[samli, 2015-09-05 00:47:40]

The CQ bit was checked by samli@chromium.org

[commit-bot: I haz the power, 2015-09-05 00:47:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312033008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312033008/20001

[commit-bot: I haz the power, 2015-09-05 04:14:06]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201844

[pfeldman, 2015-09-17 17:46:00]

It seems like the change is not doing what it claims + there was no screenshot,
so I trusted it was similar UI + just the code move. Now it is clear it was
neither of those. Also, I don't like the increased height for a component that
we considered not important / central to the experience.

https://codereview.chromium.org/1312033008/diff/20001/Source/devtools/front_e...
File Source/devtools/front_end/elements/ElementsBreadcrumbs.js (right):

https://codereview.chromium.org/1312033008/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/elements/ElementsBreadcrumbs.js:225: var margin =
parseInt(window.getComputedStyle(/** @type {!Element}
*/(crumbs.firstChild)).marginLeft, 10) * 2;
We should not use getComputedStyle.

[pfeldman, 2015-09-17 17:46:25]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1353473004/ by pfeldman@chromium.org.

The reason for reverting is: As per my comment. Not sure revert applies though..

[samli, 2015-09-17 17:51:02]

On 2015/09/17 at 17:46:00, pfeldman wrote:
> It seems like the change is not doing what it claims + there was no
screenshot, so I trusted it was similar UI + just the code move. Now it is clear
it was neither of those. Also, I don't like the increased height for a component
that we considered not important / central to the experience.

FTR, there's a screenshot in the first comment.

http://i.imgur.com/OR9ejaJ.png

[pfeldman, 2015-09-17 17:58:43]

> http://i.imgur.com/OR9ejaJ.png

Well, sorry, I missed it then. We should be posting screenshots in the relevant
bugs, especially when what you do is different from what the CL claims to.