Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312033002: DevTools: fix pretty-print of anonymous functions passed as call parameters (Closed)

Created:
5 years, 3 months ago by lushnikov
Modified:
5 years, 3 months ago
Reviewers:
sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: fix pretty-print of anonymous functions passed as call parameters BUG=520742 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201111

Patch Set 1 #

Patch Set 2 : fix stray changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M LayoutTests/inspector/sources/pretty-print-javascript-6.html View 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/inspector/sources/pretty-print-javascript-6-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/devtools/front_end/script_formatter_worker/JavaScriptFormatter.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
lushnikov
ptal
5 years, 3 months ago (2015-08-25 04:31:27 UTC) #2
sergeyv
lgtm
5 years, 3 months ago (2015-08-25 04:34:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312033002/20001
5 years, 3 months ago (2015-08-25 04:35:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103601)
5 years, 3 months ago (2015-08-25 05:23:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312033002/20001
5 years, 3 months ago (2015-08-25 08:15:34 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 08:20:06 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201111

Powered by Google App Engine
This is Rietveld 408576698