Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: Source/bindings/v8/V8GCController.cpp

Issue 131203009: Make event names of TRACE_EVENT_SAMPLING_STATE macros more descriptive (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestTypedefs.cpp ('k') | Source/bindings/v8/V8ScriptRunner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8GCController.cpp
diff --git a/Source/bindings/v8/V8GCController.cpp b/Source/bindings/v8/V8GCController.cpp
index 254ccf0a13162ab393dc6e1299cf316413fadb57..dd8662e7709d8663d927c9ebf609cac1bdb488f2 100644
--- a/Source/bindings/v8/V8GCController.cpp
+++ b/Source/bindings/v8/V8GCController.cpp
@@ -332,14 +332,14 @@ void V8GCController::minorGCPrologue(v8::Isolate* isolate)
TRACE_EVENT_BEGIN0("v8", "minorGC");
if (isMainThread()) {
{
- TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "MinorGC");
+ TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMMinorGC");
v8::HandleScope scope(isolate);
MinorGCWrapperVisitor visitor(isolate);
v8::V8::VisitHandlesForPartialDependence(isolate, &visitor);
visitor.notifyFinished();
}
V8PerIsolateData::from(isolate)->setPreviousSamplingState(TRACE_EVENT_GET_SAMPLING_STATE());
- TRACE_EVENT_SET_SAMPLING_STATE("V8", "MinorGC");
+ TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8MinorGC");
}
}
@@ -350,13 +350,13 @@ void V8GCController::majorGCPrologue(bool constructRetainedObjectInfos, v8::Isol
TRACE_EVENT_BEGIN0("v8", "majorGC");
if (isMainThread()) {
{
- TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "MajorGC");
+ TRACE_EVENT_SCOPED_SAMPLING_STATE("Blink", "DOMMajorGC");
MajorGCWrapperVisitor visitor(isolate, constructRetainedObjectInfos);
v8::V8::VisitHandlesWithClassIds(&visitor);
visitor.notifyFinished();
}
V8PerIsolateData::from(isolate)->setPreviousSamplingState(TRACE_EVENT_GET_SAMPLING_STATE());
- TRACE_EVENT_SET_SAMPLING_STATE("V8", "MajorGC");
+ TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8MajorGC");
} else {
MajorGCWrapperVisitor visitor(isolate, constructRetainedObjectInfos);
v8::V8::VisitHandlesWithClassIds(&visitor);
« no previous file with comments | « Source/bindings/tests/results/V8TestTypedefs.cpp ('k') | Source/bindings/v8/V8ScriptRunner.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698