Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: Source/bindings/templates/attributes.cpp

Issue 131203009: Make event names of TRACE_EVENT_SAMPLING_STATE macros more descriptive (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {##############################################################################} 1 {##############################################################################}
2 {% macro attribute_getter(attribute, world_suffix) %} 2 {% macro attribute_getter(attribute, world_suffix) %}
3 {% filter conditional(attribute.conditional_string) %} 3 {% filter conditional(attribute.conditional_string) %}
4 static void {{attribute.name}}AttributeGetter{{world_suffix}}( 4 static void {{attribute.name}}AttributeGetter{{world_suffix}}(
5 {%- if attribute.is_expose_js_accessors %} 5 {%- if attribute.is_expose_js_accessors %}
6 const v8::FunctionCallbackInfo<v8::Value>& info 6 const v8::FunctionCallbackInfo<v8::Value>& info
7 {%- else %} 7 {%- else %}
8 const v8::PropertyCallbackInfo<v8::Value>& info 8 const v8::PropertyCallbackInfo<v8::Value>& info
9 {%- endif %}) 9 {%- endif %})
10 { 10 {
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 {% if world_suffix in attribute.activity_logging_world_list_for_getter %} 106 {% if world_suffix in attribute.activity_logging_world_list_for_getter %}
107 V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->Ge tCurrentContext()); 107 V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->Ge tCurrentContext());
108 if (contextData && contextData->activityLogger()) 108 if (contextData && contextData->activityLogger())
109 contextData->activityLogger()->log("{{interface_name}}.{{attribute.name} }", 0, 0, "Getter"); 109 contextData->activityLogger()->log("{{interface_name}}.{{attribute.name} }", 0, 0, "Getter");
110 {% endif %} 110 {% endif %}
111 {% if attribute.has_custom_getter %} 111 {% if attribute.has_custom_getter %}
112 {{v8_class}}::{{attribute.name}}AttributeGetterCustom(info); 112 {{v8_class}}::{{attribute.name}}AttributeGetterCustom(info);
113 {% else %} 113 {% else %}
114 {{cpp_class}}V8Internal::{{attribute.name}}AttributeGetter{{world_suffix}}(i nfo); 114 {{cpp_class}}V8Internal::{{attribute.name}}AttributeGetter{{world_suffix}}(i nfo);
115 {% endif %} 115 {% endif %}
116 TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution"); 116 TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
117 } 117 }
118 {% endfilter %} 118 {% endfilter %}
119 {% endmacro %} 119 {% endmacro %}
120 120
121 121
122 {##############################################################################} 122 {##############################################################################}
123 {% macro attribute_setter(attribute, world_suffix) %} 123 {% macro attribute_setter(attribute, world_suffix) %}
124 {% filter conditional(attribute.conditional_string) %} 124 {% filter conditional(attribute.conditional_string) %}
125 static void {{attribute.name}}AttributeSetter{{world_suffix}}( 125 static void {{attribute.name}}AttributeSetter{{world_suffix}}(
126 {%- if attribute.is_expose_js_accessors %} 126 {%- if attribute.is_expose_js_accessors %}
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 } 211 }
212 {% endif %} 212 {% endif %}
213 {% if attribute.is_reflect %} 213 {% if attribute.is_reflect %}
214 CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope; 214 CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
215 {% endif %} 215 {% endif %}
216 {% if attribute.has_custom_setter %} 216 {% if attribute.has_custom_setter %}
217 {{v8_class}}::{{attribute.name}}AttributeSetterCustom(jsValue, info); 217 {{v8_class}}::{{attribute.name}}AttributeSetterCustom(jsValue, info);
218 {% else %} 218 {% else %}
219 {{cpp_class}}V8Internal::{{attribute.name}}AttributeSetter{{world_suffix}}(j sValue, info); 219 {{cpp_class}}V8Internal::{{attribute.name}}AttributeSetter{{world_suffix}}(j sValue, info);
220 {% endif %} 220 {% endif %}
221 TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution"); 221 TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
222 } 222 }
223 {% endfilter %} 223 {% endfilter %}
224 {% endmacro %} 224 {% endmacro %}
OLDNEW
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698