Issue 131203009: Make event names of TRACE_EVENT_SAMPLING_STATE macros more descriptive

Issue 131203009: Make event names of TRACE_EVENT_SAMPLING_STATE macros more descriptive (Closed)

Created:
6 years, 11 months ago by haraken

Modified:
6 years, 11 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make event names of TRACE_EVENT_SAMPLING_STATE macros more descriptive "Execution" => "V8Execution" "MinorGC" => "V8MinorGC" and "DOMMinorGC" "MajorGC" => "V8MajorGC" and "DOMMajorGC" etc Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165076

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+877 lines, -876 lines)			Patch
M	Source/bindings/scripts/code_generator_v8.pm	View	1	13 chunks	+13 lines, -13 lines	0 comments	Download
M	Source/bindings/templates/attributes.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/templates/interface.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/templates/methods.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8SupportTestInterface.cpp	View		18 chunks	+18 lines, -18 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestCustomAccessors.cpp	View		1 chunk	+9 lines, -9 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestEventTarget.cpp	View		9 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestException.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestInterface.cpp	View	1	39 chunks	+44 lines, -44 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp	View		18 chunks	+18 lines, -18 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp	View		12 chunks	+12 lines, -12 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestInterfaceNode.cpp	View	1	10 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestInterfacePython.cpp	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestNode.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View	1	280 chunks	+285 lines, -285 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObjectPython.cpp	View	1	384 chunks	+392 lines, -392 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestSVG.cpp	View	1	12 chunks	+12 lines, -12 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestTypedefs.cpp	View	1	17 chunks	+17 lines, -17 lines	0 comments	Download
M	Source/bindings/v8/V8GCController.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/bindings/v8/V8ScriptRunner.cpp	View		11 chunks	+11 lines, -11 lines	0 comments	Download
M	Source/bindings/v8/V8WindowShell.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/platform/ThreadTimers.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

This is a preparation CL for enabling the sampling profiler. abarth: rubberstamp please?

6 years, 11 months ago (2014-01-14 01:18:36 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/131203009/1

6 years, 11 months ago (2014-01-14 04:28:52 UTC) #3

commit-bot: I haz the power

Failed to apply patch for Source/bindings/tests/results/V8TestObject.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

6 years, 11 months ago (2014-01-14 04:29:14 UTC) #4

Failed to apply patch for Source/bindings/tests/results/V8TestObject.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/results/V8TestObject.cpp
  Hunk #1 succeeded at 107 (offset -5 lines).
  Hunk #2 succeeded at 120 (offset -5 lines).
  Hunk #3 succeeded at 140 (offset -5 lines).
  Hunk #4 succeeded at 152 (offset -5 lines).
  Hunk #5 succeeded at 164 (offset -5 lines).
  Hunk #6 succeeded at 177 (offset -5 lines).
  Hunk #7 succeeded at 190 (offset -5 lines).
  Hunk #8 succeeded at 207 (offset -5 lines).
  Hunk #9 succeeded at 220 (offset -5 lines).
  Hunk #10 succeeded at 233 (offset -5 lines).
  Hunk #11 succeeded at 248 (offset -5 lines).
  Hunk #12 succeeded at 261 (offset -5 lines).
  Hunk #13 succeeded at 276 (offset -5 lines).
  Hunk #14 succeeded at 289 (offset -5 lines).
  Hunk #15 succeeded at 304 (offset -5 lines).
  Hunk #16 succeeded at 317 (offset -5 lines).
  Hunk #17 succeeded at 332 (offset -5 lines).
  Hunk #18 succeeded at 345 (offset -5 lines).
  Hunk #19 succeeded at 360 (offset -5 lines).
  Hunk #20 succeeded at 373 (offset -5 lines).
  Hunk #21 succeeded at 388 (offset -5 lines).
  Hunk #22 succeeded at 401 (offset -5 lines).
  Hunk #23 succeeded at 416 (offset -5 lines).
  Hunk #24 succeeded at 429 (offset -5 lines).
  Hunk #25 succeeded at 443 (offset -5 lines).
  Hunk #26 succeeded at 457 (offset -5 lines).
  Hunk #27 succeeded at 471 (offset -5 lines).
  Hunk #28 succeeded at 485 (offset -5 lines).
  Hunk #29 succeeded at 500 (offset -5 lines).
  Hunk #30 succeeded at 513 (offset -5 lines).
  Hunk #31 succeeded at 528 (offset -5 lines).
  Hunk #32 succeeded at 541 (offset -5 lines).
  Hunk #33 succeeded at 555 (offset -5 lines).
  Hunk #34 succeeded at 568 (offset -5 lines).
  Hunk #35 succeeded at 582 (offset -5 lines).
  Hunk #36 succeeded at 595 (offset -5 lines).
  Hunk #37 succeeded at 611 (offset -5 lines).
  Hunk #38 succeeded at 624 (offset -5 lines).
  Hunk #39 succeeded at 641 (offset -5 lines).
  Hunk #40 succeeded at 654 (offset -5 lines).
  Hunk #41 succeeded at 671 (offset -5 lines).
  Hunk #42 succeeded at 684 (offset -5 lines).
  Hunk #43 succeeded at 700 (offset -5 lines).
  Hunk #44 succeeded at 713 (offset -5 lines).
  Hunk #45 succeeded at 729 (offset -5 lines).
  Hunk #46 succeeded at 742 (offset -5 lines).
  Hunk #47 succeeded at 758 (offset -5 lines).
  Hunk #48 succeeded at 771 (offset -5 lines).
  Hunk #49 succeeded at 788 (offset -5 lines).
  Hunk #50 succeeded at 801 (offset -5 lines).
  Hunk #51 succeeded at 817 (offset -5 lines).
  Hunk #52 succeeded at 830 (offset -5 lines).
  Hunk #53 succeeded at 846 with fuzz 1 (offset -5 lines).
  Hunk #54 FAILED at 864.
  Hunk #55 FAILED at 880.
  Hunk #56 succeeded at 867 (offset -34 lines).
  Hunk #57 succeeded at 883 (offset -34 lines).
  Hunk #58 succeeded at 908 (offset -34 lines).
  Hunk #59 succeeded at 924 (offset -34 lines).
  Hunk #60 succeeded at 947 (offset -34 lines).
  Hunk #61 succeeded at 963 (offset -34 lines).
  Hunk #62 succeeded at 986 (offset -34 lines).
  Hunk #63 succeeded at 1002 (offset -34 lines).
  Hunk #64 succeeded at 1027 (offset -34 lines).
  Hunk #65 succeeded at 1043 (offset -34 lines).
  Hunk #66 succeeded at 1066 (offset -34 lines).
  Hunk #67 succeeded at 1082 (offset -34 lines).
  Hunk #68 succeeded at 1107 (offset -34 lines).
  Hunk #69 succeeded at 1136 (offset -34 lines).
  Hunk #70 succeeded at 1149 (offset -34 lines).
  Hunk #71 succeeded at 1163 (offset -34 lines).
  Hunk #72 succeeded at 1180 (offset -34 lines).
  Hunk #73 succeeded at 1195 (offset -34 lines).
  Hunk #74 succeeded at 1208 (offset -34 lines).
  Hunk #75 succeeded at 1224 (offset -34 lines).
  Hunk #76 succeeded at 1241 (offset -34 lines).
  Hunk #77 succeeded at 1255 (offset -34 lines).
  Hunk #78 succeeded at 1268 (offset -34 lines).
  Hunk #79 succeeded at 1284 (offset -34 lines).
  Hunk #80 succeeded at 1315 (offset -34 lines).
  Hunk #81 succeeded at 1336 (offset -34 lines).
  Hunk #82 succeeded at 1350 (offset -34 lines).
  Hunk #83 succeeded at 1365 (offset -34 lines).
  Hunk #84 succeeded at 1378 (offset -34 lines).
  Hunk #85 succeeded at 1392 (offset -34 lines).
  Hunk #86 succeeded at 1417 (offset -34 lines).
  Hunk #87 succeeded at 1437 (offset -34 lines).
  Hunk #88 succeeded at 1455 (offset -34 lines).
  Hunk #89 succeeded at 1470 (offset -34 lines).
  Hunk #90 succeeded at 1488 (offset -34 lines).
  Hunk #91 succeeded at 1509 (offset -34 lines).
  Hunk #92 succeeded at 1535 (offset -34 lines).
  Hunk #93 succeeded at 1556 (offset -34 lines).
  Hunk #94 succeeded at 1574 (offset -34 lines).
  Hunk #95 succeeded at 1595 (offset -34 lines).
  Hunk #96 succeeded at 1608 (offset -34 lines).
  Hunk #97 succeeded at 1623 (offset -34 lines).
  Hunk #98 succeeded at 1636 (offset -34 lines).
  Hunk #99 succeeded at 1651 (offset -34 lines).
  Hunk #100 succeeded at 1664 (offset -34 lines).
  Hunk #101 succeeded at 1679 (offset -34 lines).
  Hunk #102 succeeded at 1692 (offset -34 lines).
  Hunk #103 succeeded at 1707 (offset -34 lines).
  Hunk #104 succeeded at 1720 (offset -34 lines).
  Hunk #105 succeeded at 1735 (offset -34 lines).
  Hunk #106 succeeded at 1748 (offset -34 lines).
  Hunk #107 succeeded at 1763 (offset -34 lines).
  Hunk #108 succeeded at 1776 (offset -34 lines).
  Hunk #109 succeeded at 1791 (offset -34 lines).
  Hunk #110 succeeded at 1804 (offset -34 lines).
  Hunk #111 succeeded at 1819 (offset -34 lines).
  Hunk #112 succeeded at 1835 (offset -34 lines).
  Hunk #113 succeeded at 1854 (offset -34 lines).
  Hunk #114 succeeded at 1871 (offset -34 lines).
  Hunk #115 succeeded at 1890 (offset -34 lines).
  Hunk #116 succeeded at 1907 (offset -34 lines).
  Hunk #117 succeeded at 1926 (offset -34 lines).
  Hunk #118 succeeded at 1940 (offset -34 lines).
  Hunk #119 succeeded at 1953 (offset -34 lines).
  Hunk #120 succeeded at 1976 (offset -34 lines).
  Hunk #121 succeeded at 2002 (offset -34 lines).
  Hunk #122 succeeded at 2015 (offset -34 lines).
  Hunk #123 succeeded at 2029 (offset -34 lines).
  Hunk #124 succeeded at 2042 (offset -34 lines).
  Hunk #125 succeeded at 2056 (offset -34 lines).
  Hunk #126 succeeded at 2069 (offset -34 lines).
  Hunk #127 succeeded at 2084 (offset -34 lines).
  Hunk #128 succeeded at 2097 (offset -34 lines).
  Hunk #129 succeeded at 2112 (offset -34 lines).
  Hunk #130 succeeded at 2125 (offset -34 lines).
  Hunk #131 succeeded at 2139 (offset -34 lines).
  Hunk #132 succeeded at 2152 (offset -34 lines).
  Hunk #133 succeeded at 2166 (offset -34 lines).
  Hunk #134 succeeded at 2179 (offset -34 lines).
  Hunk #135 succeeded at 2193 (offset -34 lines).
  Hunk #136 succeeded at 2212 with fuzz 1 (offset -34 lines).
  Hunk #137 FAILED at 2259.
  Hunk #138 FAILED at 2279.
  Hunk #139 FAILED at 2292.
  Hunk #140 FAILED at 2312.
  Hunk #141 succeeded at 2225 (offset -100 lines).
  Hunk #142 succeeded at 2240 (offset -100 lines).
  Hunk #143 succeeded at 2253 (offset -100 lines).
  Hunk #144 succeeded at 2267 (offset -100 lines).
  Hunk #145 succeeded at 2280 (offset -100 lines).
  Hunk #146 succeeded at 2299 (offset -100 lines).
  Hunk #147 succeeded at 2318 (offset -100 lines).
  Hunk #148 succeeded at 2337 (offset -100 lines).
  Hunk #149 succeeded at 2356 (offset -100 lines).
  Hunk #150 succeeded at 2375 (offset -100 lines).
  Hunk #151 succeeded at 2390 (offset -100 lines).
  Hunk #152 succeeded at 2412 (offset -100 lines).
  Hunk #153 succeeded at 2427 (offset -100 lines).
  Hunk #154 succeeded at 2447 (offset -100 lines).
  Hunk #155 succeeded at 2467 (offset -100 lines).
  Hunk #156 succeeded at 2480 (offset -100 lines).
  Hunk #157 succeeded at 2494 (offset -100 lines).
  Hunk #158 succeeded at 2507 (offset -100 lines).
  Hunk #159 succeeded at 2521 (offset -100 lines).
  Hunk #160 succeeded at 2537 (offset -100 lines).
  Hunk #161 succeeded at 2557 (offset -100 lines).
  Hunk #162 succeeded at 2573 (offset -100 lines).
  Hunk #163 succeeded at 2593 (offset -100 lines).
  Hunk #164 succeeded at 2609 (offset -100 lines).
  Hunk #165 succeeded at 2629 (offset -100 lines).
  Hunk #166 succeeded at 2645 (offset -100 lines).
  Hunk #167 succeeded at 2665 (offset -100 lines).
  Hunk #168 succeeded at 2678 (offset -100 lines).
  Hunk #169 succeeded at 2693 (offset -100 lines).
  Hunk #170 succeeded at 2706 (offset -100 lines).
  Hunk #171 succeeded at 2726 (offset -100 lines).
  Hunk #172 succeeded at 2739 (offset -100 lines).
  Hunk #173 succeeded at 2759 (offset -100 lines).
  Hunk #174 succeeded at 2772 (offset -100 lines).
  Hunk #175 succeeded at 2792 (offset -100 lines).
  Hunk #176 succeeded at 2805 (offset -100 lines).
  Hunk #177 succeeded at 2825 (offset -100 lines).
  Hunk #178 succeeded at 2838 (offset -100 lines).
  Hunk #179 succeeded at 2853 (offset -100 lines).
  Hunk #180 succeeded at 2869 (offset -100 lines).
  Hunk #181 succeeded at 2884 (offset -100 lines).
  Hunk #182 succeeded at 2900 (offset -100 lines).
  Hunk #183 succeeded at 2915 (offset -100 lines).
  Hunk #184 succeeded at 2931 (offset -100 lines).
  Hunk #185 succeeded at 2946 (offset -100 lines).
  Hunk #186 succeeded at 2962 (offset -100 lines).
  Hunk #187 succeeded at 2977 (offset -100 lines).
  Hunk #188 succeeded at 2990 (offset -100 lines).
  Hunk #189 succeeded at 3005 (offset -100 lines).
  Hunk #190 succeeded at 3018 (offset -100 lines).
  Hunk #191 succeeded at 3031 (offset -100 lines).
  Hunk #192 succeeded at 3046 (offset -100 lines).
  Hunk #193 succeeded at 3060 (offset -100 lines).
  Hunk #194 succeeded at 3074 (offset -100 lines).
  Hunk #195 succeeded at 3090 (offset -100 lines).
  Hunk #196 succeeded at 3103 (offset -100 lines).
  Hunk #197 succeeded at 3120 (offset -100 lines).
  Hunk #198 succeeded at 3133 (offset -100 lines).
  Hunk #199 succeeded at 3150 (offset -100 lines).
  Hunk #200 succeeded at 3183 (offset -100 lines).
  Hunk #201 succeeded at 3210 (offset -100 l…
(message too large)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/131203009/240001

6 years, 11 months ago (2014-01-14 14:26:33 UTC) #5

Message was sent while issue was closed.

Change committed as 165076

Expand Messages | Collapse Messages