Issue 131203005: Split WebRTC browser tests in getusermedia and peerconnection tests.

Issue 131203005: Split WebRTC browser tests in getusermedia and peerconnection tests. (Closed)

Created:
6 years, 11 months ago by phoglund_chromium

Modified:
6 years, 11 months ago

Reviewers:
tommi (sloooow) - chröme, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Split WebRTC browser tests in getusermedia and peerconnection tests. The content browsertests file for WebRTC was growing a bit large. I extracted the getUserMedia-focused tests into a test of its own and left the peerconnection tests. Also renamed all WebRTC content browsertests to use the WebRtc naming convention, which seems to be the most common in the production code. Note: this patch will require some filter renames on the WebRTC bots. R=tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245524

Patch Set 1 #

Patch Set 2 : Correcting Android disabled file. #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Fixed merge bugs, moved fixtures. #

Patch Set 5 : Rebased #

Patch Set 6 : Rebased again :) #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+592 lines, -559 lines)			Patch
M	build/android/pylib/gtest/filter/content_browsertests_disabled	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	content/browser/media/webrtc_aecdump_browsertest.cc	View	1 2 3	4 chunks	+10 lines, -22 lines	0 comments	Download
M	content/browser/media/webrtc_browsertest.cc	View	1 2 3 4 5	20 chunks	+30 lines, -530 lines	0 comments	Download
A	content/browser/media/webrtc_getusermedia_browsertest.cc	View	1 2 3 4 5	1 chunk	+427 lines, -0 lines	0 comments	Download
M	content/browser/media/webrtc_internals.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/content_tests.gypi	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
A	content/test/webrtc_content_browsertest_base.h	View	1 2 3 4	1 chunk	+39 lines, -0 lines	0 comments	Download
A	content/test/webrtc_content_browsertest_base.cc	View	1 2 3 4	1 chunk	+76 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

phoglund_chromium

jam: please review content_tests.gypi changes.

6 years, 11 months ago (2014-01-15 17:39:20 UTC) #3

jam

lgtm with comments https://codereview.chromium.org/131203005/diff/80001/content/browser/media/webrtc_content_browsertest_base.h File content/browser/media/webrtc_content_browsertest_base.h (right): https://codereview.chromium.org/131203005/diff/80001/content/browser/media/webrtc_content_browsertest_base.h#newcode1 content/browser/media/webrtc_content_browsertest_base.h:1: // Copyright (c) 2012 The Chromium ...

6 years, 11 months ago (2014-01-15 18:00:08 UTC) #4

phoglund_chromium

https://codereview.chromium.org/131203005/diff/80001/content/browser/media/webrtc_content_browsertest_base.h File content/browser/media/webrtc_content_browsertest_base.h (right): https://codereview.chromium.org/131203005/diff/80001/content/browser/media/webrtc_content_browsertest_base.h#newcode1 content/browser/media/webrtc_content_browsertest_base.h:1: // Copyright (c) 2012 The Chromium Authors. All rights ...

6 years, 11 months ago (2014-01-16 14:30:31 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/131203005/440002

6 years, 11 months ago (2014-01-17 12:22:19 UTC) #6

Message was sent while issue was closed.

Change committed as 245524

Expand Messages | Collapse Messages