components/translate/core/browser/translate_browser_metrics.h - Issue 131203002: Move LanguageUsageMetrics and TranslateBrowserMetrics to components

Side by Side Diff: components/translate/core/browser/translate_browser_metrics.h

Issue 131203002: Move LanguageUsageMetrics and TranslateBrowserMetrics to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/language_usage_metrics/language_usage_metrics.h ('K') | « components/translate/DEPS ('k') | components/translate/core/browser/translate_browser_metrics.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_BROWSER_METRICS_H_	5 #ifndef COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_BROWSER_METRICS_H_

6 #define CHROME_BROWSER_TRANSLATE_TRANSLATE_BROWSER_METRICS_H_	6 #define COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_BROWSER_METRICS_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 namespace TranslateBrowserMetrics {	10 namespace TranslateBrowserMetrics {
	Jói 2014/01/09 10:44:14 As per my other comment, this code should be in na As per my other comment, this code should be in namespace translate (and thus you could rename this inner namespace from TranslateBrowserMetrics to just BrowserMetrics) but I don't mind if you do this in a follow-up. blundell 2014/01/09 10:47:04 Jói: For iterative refactorings, we were planning Jói: For iterative refactorings, we were planning on introducing the namespace at the conclusion of the refactoring in order to avoid churn on files that have not yet moved into the component but will do so in succeeding CLs. Does that sound OK to you as a general approach? On 2014/01/09 10:44:14, Jói wrote: Show quoted text > As per my other comment, this code should be in namespace translate (and thus > you could rename this inner namespace from TranslateBrowserMetrics to just > BrowserMetrics) but I don't mind if you do this in a follow-up. droger 2014/01/09 11:52:28 As blundell said, I'll do that later. I'm tracking Show quoted text On 2014/01/09 10:47:04, blundell wrote: > Jói: For iterative refactorings, we were planning on introducing the namespace > at the conclusion of the refactoring in order to avoid churn on files that have > not yet moved into the component but will do so in succeeding CLs. Does that > sound OK to you as a general approach? > > On 2014/01/09 10:44:14, Jói wrote: > > As per my other comment, this code should be in namespace translate (and thus > > you could rename this inner namespace from TranslateBrowserMetrics to just > > BrowserMetrics) but I don't mind if you do this in a follow-up. > As blundell said, I'll do that later. I'm tracking this as http://crbug.com/331782
11	11

12 // An indexing type to query each UMA entry name via GetMetricsName() function.	12 // An indexing type to query each UMA entry name via GetMetricsName() function.

13 // Note: \|kMetricsEntries\| should be updated when a new entry is added here.	13 // Note: \|kMetricsEntries\| should be updated when a new entry is added here.

14 enum MetricsNameIndex {	14 enum MetricsNameIndex {

15 UMA_INITIATION_STATUS,	15 UMA_INITIATION_STATUS,

16 UMA_LANGUAGE_DETECTION_ERROR,	16 UMA_LANGUAGE_DETECTION_ERROR,

17 UMA_LOCALES_ON_DISABLED_BY_PREFS,	17 UMA_LOCALES_ON_DISABLED_BY_PREFS,

18 UMA_UNDISPLAYABLE_LANGUAGE,	18 UMA_UNDISPLAYABLE_LANGUAGE,

19 UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION,	19 UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION,

20 UMA_MAX,	20 UMA_MAX,

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
54 // a undisplayable language in the user's locale.	54 // a undisplayable language in the user's locale.

55 void ReportUndisplayableLanguage(const std::string& language);	55 void ReportUndisplayableLanguage(const std::string& language);

56	56

57 void ReportUnsupportedLanguageAtInitiation(const std::string& language);	57 void ReportUnsupportedLanguageAtInitiation(const std::string& language);

58	58

59 // Provides UMA entry names for unit tests.	59 // Provides UMA entry names for unit tests.

60 const char* GetMetricsName(MetricsNameIndex index);	60 const char* GetMetricsName(MetricsNameIndex index);

61	61

62 } // namespace TranslateBrowserMetrics	62 } // namespace TranslateBrowserMetrics

63	63

64 #endif // CHROME_BROWSER_TRANSLATE_TRANSLATE_BROWSER_METRICS_H_	64 #endif // COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_BROWSER_METRICS_H_

OLD	NEW