Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1312023003:
Make getComputedStyle(e).transform return correct values for non-transformable elements (Closed)
|
Created:
5 years, 4 months ago by nainar Modified:
5 years, 4 months ago CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionMake getComputedStyle(e).transform return correct values for non-transformable elements
getComputedStyle(e).transform currently doesn't return the correct
values for non-transformable elements. Both FF and IE return the correct
values. This patch makes getComputedStyle(e).transform return the
correct value for non-transformable elements as well.
BUG=517620
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201174
Patch Set 1 #
Messages
Total messages: 23 (10 generated)
nainar@google.com changed reviewers: + timloh@chromium.org
I've submitted the patch to the try server. Could you take a look at it in the meanwhile? Thanks!
On 2015/08/25 03:11:30, nainar wrote: > I've submitted the patch to the try server. > > Could you take a look at it in the meanwhile? > > Thanks! lgtm
The CQ bit was checked by nainar@google.com
On 2015/08/25 04:30:44, Timothy Loh wrote: > On 2015/08/25 03:11:30, nainar wrote: > > I've submitted the patch to the try server. > > > > Could you take a look at it in the meanwhile? > > > > Thanks! > > lgtm but update the patch title/description to suggest it's for transform instead of just talking about transformation matrices...
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312023003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by nainar@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312023003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by nainar@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312023003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by nainar@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312023003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by nainar@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312023003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201174 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
