Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311963007: switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE (Closed)

Created:
5 years, 3 months ago by reed2
Modified:
5 years, 3 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

switch to isABitmap, deprecate SK_SUPPORT_LEGACY_SHADERBITMAPTYPE BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/2d126b5c45e65a67a9945afa9294038a8eb3f2c8

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -48 lines) Patch
M include/core/SkShader.h View 1 2 2 chunks +11 lines, -33 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/core/SkLocalMatrixShader.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M src/core/SkShader.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311963007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311963007/1
5 years, 3 months ago (2015-09-07 15:18:22 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3035) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
5 years, 3 months ago (2015-09-07 15:19:24 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311963007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311963007/20001
5 years, 3 months ago (2015-09-07 18:01:36 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/3122) Build-Ubuntu-GCC-x86_64-Release-Trybot on ...
5 years, 3 months ago (2015-09-07 18:02:17 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311963007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311963007/40001
5 years, 3 months ago (2015-09-07 18:04:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311963007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311963007/40001
5 years, 3 months ago (2015-09-07 18:10:06 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/2d126b5c45e65a67a9945afa9294038a8eb3f2c8
5 years, 3 months ago (2015-09-07 18:10:35 UTC) #14
jcgregorio
On 2015/09/07 at 18:10:35, commit-bot wrote: > Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/2d126b5c45e65a67a9945afa9294038a8eb3f2c8 Seems to ...
5 years, 3 months ago (2015-09-08 08:05:51 UTC) #15
scroggo
5 years, 3 months ago (2015-09-08 13:23:57 UTC) #16
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1309943004/ by scroggo@google.com.

The reason for reverting is: Broke the Android canary:

  https://internal.skia.org/builders/crimson-cherry-474438/builds/124.

Powered by Google App Engine
This is Rietveld 408576698