Issue 1311933003: Deflake http/tests/serviceworker/request-end-to-end.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1311933003: Deflake http/tests/serviceworker/request-end-to-end.html (Closed)

Created:
5 years, 3 months ago by falken

Modified:
5 years, 3 months ago

Reviewers:
horo

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Deflake http/tests/serviceworker/request-end-to-end.html The test was timing out, it's not clear why but the code was fairly complex. Simplify by avoiding messaging and just return the result in the response to onfetch. BUG=518985 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201388

Patch Set 1 #

Patch Set 2 : text expectations #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -69 lines)			Patch
M	LayoutTests/TestExpectations	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/http/tests/serviceworker/request-end-to-end.html	View		1 chunk	+21 lines, -48 lines	0 comments	Download
M	LayoutTests/http/tests/serviceworker/resources/request-end-to-end-worker.js	View		1 chunk	+11 lines, -20 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311933003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311933003/20001

5 years, 3 months ago (2015-08-28 09:29:31 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-08-28 10:09:52 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201388

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages