Issue 131193005: Enable unwind support with buildtype=Official branding=Chrome in Debug mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131193005: Enable unwind support with buildtype=Official branding=Chrome in Debug mode (Closed)

Created:
6 years, 11 months ago by spang

Modified:
6 years, 11 months ago

Reviewers:
James Cook, Nico

CC:
chromium-reviews, James Cook

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable unwind support with buildtype=Official branding=Chrome in Debug mode The previous patch removed unwind support on x64 official builds, including Debug builds. That may have been a bit too far. Add it back to Debug builds (but not Release builds). BUG=180975 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244331

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -9 lines)			Patch
	M	build/common.gypi	View		5 chunks	+15 lines, -9 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nico

jamescook: Can you check that this fixes the issue you reported on "[chromium-dev] state of ...

6 years, 11 months ago (2014-01-10 21:18:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/131193005/1

6 years, 11 months ago (2014-01-10 21:44:14 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/131193005/1

6 years, 11 months ago (2014-01-10 23:31:01 UTC) #6

Message was sent while issue was closed.

Change committed as 244331

Expand Messages | Collapse Messages