Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311923004: Rename FormData/FormDataBuilder to EncodedFormData/FormDataEncoder respectively. (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
keishi, yhirano
CC:
blink-reviews, mkwst+watchlist-csp_chromium.org, caseq+blink_chromium.org, vivekg_samsung, vivekg, gavinp+loader_chromium.org, tyoshino+watch_chromium.org, blink-reviews-html_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, kinuko+watch, Nate Chapin, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename FormData/FormDataBuilder to EncodedFormData/FormDataEncoder respectively. The XHR specification defines 'FormData' interface [1], but the blink::FormData is not its implementation. It's confusing. A later patch will rename DOMFormData to FormData. This CL has no behavior changes. [1] https://xhr.spec.whatwg.org/#interface-formdata BUG=528840 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201953

Patch Set 1 #

Total comments: 9

Patch Set 2 : update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -1017 lines) Patch
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/FormDataList.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/FormDataList.cpp View 1 6 chunks +17 lines, -15 lines 0 comments Download
M Source/core/html/parser/XSSAuditor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/XSSAuditorDelegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/XSSAuditorDelegate.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/AsyncCallTracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/AsyncCallTracker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorInstrumentation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/NetworkResourcesData.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/NetworkResourcesData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/BeaconLoader.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/loader/FormSubmission.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/loader/FormSubmission.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/HistoryItem.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/loader/HistoryItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/PingLoader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/PingLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 9 chunks +11 lines, -11 lines 0 comments Download
M Source/modules/fetch/BodyStreamBuffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/fetch/BodyStreamBuffer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/fetch/FetchBlobDataConsumerHandle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/fetch/FetchDataConsumerHandle.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/fetch/FetchFormDataConsumerHandle.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/fetch/FetchFormDataConsumerHandle.cpp View 1 13 chunks +18 lines, -18 lines 0 comments Download
M Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp View 11 chunks +14 lines, -14 lines 0 comments Download
M Source/modules/fetch/RequestInit.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/fetch/Response.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/blink_platform.gypi View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/exported/WebHTTPBody.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
A + Source/platform/network/EncodedFormData.h View 6 chunks +16 lines, -16 lines 0 comments Download
A + Source/platform/network/EncodedFormData.cpp View 6 chunks +28 lines, -28 lines 0 comments Download
A + Source/platform/network/EncodedFormDataTest.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
D Source/platform/network/FormData.h View 1 chunk +0 lines, -162 lines 0 comments Download
D Source/platform/network/FormData.cpp View 1 chunk +0 lines, -208 lines 0 comments Download
D Source/platform/network/FormDataBuilder.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/platform/network/FormDataBuilder.cpp View 1 chunk +0 lines, -226 lines 0 comments Download
A + Source/platform/network/FormDataEncoder.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + Source/platform/network/FormDataEncoder.cpp View 10 chunks +17 lines, -17 lines 0 comments Download
D Source/platform/network/FormDataTest.cpp View 1 chunk +0 lines, -116 lines 0 comments Download
M Source/platform/network/ResourceRequest.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/network/ResourceRequest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/network/ResourceRequestTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebHistoryItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebSearchableFormData.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M public/platform/WebHTTPBody.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tkent
keishi or yhirano, would you review this please?
5 years, 3 months ago (2015-09-09 01:16:20 UTC) #2
yhirano
lgtm https://codereview.chromium.org/1311923004/diff/1/Source/core/html/FormDataList.cpp File Source/core/html/FormDataList.cpp (right): https://codereview.chromium.org/1311923004/diff/1/Source/core/html/FormDataList.cpp#newcode158 Source/core/html/FormDataList.cpp:158: // If a filename is passed in FormData.append(), ...
5 years, 3 months ago (2015-09-09 02:14:21 UTC) #3
tkent
Thank you for reviewing. https://codereview.chromium.org/1311923004/diff/1/Source/core/html/FormDataList.cpp File Source/core/html/FormDataList.cpp (right): https://codereview.chromium.org/1311923004/diff/1/Source/core/html/FormDataList.cpp#newcode158 Source/core/html/FormDataList.cpp:158: // If a filename is ...
5 years, 3 months ago (2015-09-09 02:22:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311923004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311923004/20001
5 years, 3 months ago (2015-09-09 02:24:46 UTC) #7
yhirano
https://codereview.chromium.org/1311923004/diff/1/Source/core/html/FormDataList.cpp File Source/core/html/FormDataList.cpp (right): https://codereview.chromium.org/1311923004/diff/1/Source/core/html/FormDataList.cpp#newcode158 Source/core/html/FormDataList.cpp:158: // If a filename is passed in FormData.append(), use ...
5 years, 3 months ago (2015-09-09 02:25:51 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 04:35:17 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201953

Powered by Google App Engine
This is Rietveld 408576698