chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java - Issue 1311913007: Do not select a Tab while closing all tabs or undoing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

Issue 1311913007: Do not select a Tab while closing all tabs or undoing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

index 5d3b18474e495afb9f421882018d600425b500ff..afbf0ec179546c0f432d43c293b7b2a723ad3291 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

@@ -106,7 +106,7 @@ public class UndoTabModelTest extends ChromeTabbedActivityTestBase {

@Override

public void run() {

// Take action.

- model.closeTab(tab, true, false, undoable);

+ model.closeTab(tab, true, false, undoable, false);

}

});

@@ -166,7 +166,7 @@ public class UndoTabModelTest extends ChromeTabbedActivityTestBase {

@Override

public void run() {

// Take action.

- model.cancelTabClosure(tab.getId());

+ model.cancelTabClosure(tab.getId(), false);

}

});

@@ -209,7 +209,7 @@ public class UndoTabModelTest extends ChromeTabbedActivityTestBase {

public void run() {

for (int i = 0; i < expectedToClose.length; i++) {

Tab tab = expectedToClose[i];

- model.cancelTabClosure(tab.getId());

+ model.cancelTabClosure(tab.getId(), i != expectedToClose.length - 1);

}

});