chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java - Issue 1311913007: Do not select a Tab while closing all tabs or undoing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

Issue 1311913007: Do not select a Tab while closing all tabs or undoing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelUtils.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

index 61094b0397ac88b2e3a2776211685c5e6d706724..9c5cf25cc2dc8d2a6324401692a3e28964a74564 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

@@ -328,11 +328,12 @@ public class DocumentTabModelImpl extends TabModelJniBridge implements DocumentT

@Override

public boolean closeTab(Tab tab) {

- return closeTab(tab, false, false, false);

+ return closeTab(tab, false, false, false, false);

}

@Override

- public boolean closeTab(Tab tabToClose, boolean animate, boolean uponExit, boolean canUndo) {

+ public boolean closeTab(Tab tabToClose, boolean animate, boolean uponExit, boolean canUndo,

+ boolean closingAll) {

// The tab should be destroyed by the DocumentActivity that owns it.

return closeTabAt(indexOf(tabToClose.getId()));

}

@@ -865,8 +866,7 @@ public class DocumentTabModelImpl extends TabModelJniBridge implements DocumentT

}

@Override

- public void cancelTabClosure(int tabId) {

- }

+ public void cancelTabClosure(int tabId, boolean isHidden) {}

@Override

public TabList getComprehensiveModel() {