Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1311913006: Use PositionWithAffinity as internal representation of VisiblePostion (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use PositionWithAffinity as internal representation of VisiblePostion This patch replaces member variables |Position| and |TextAffinity| in |VisiblePostion| class to |PositionWithAffinity| to simplify construction of an object for preparation of templatizing |VisiblePostion| to introduce composed tree version. This patch also moves default constructor into .cpp file from header file to reduce size of header file. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201619

Patch Set 1 : 2015-09-02T14:43:03 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M Source/core/editing/VisiblePosition.h View 3 chunks +9 lines, -12 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 2 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-02 06:00:18 UTC) #2
yoichio
lgtm
5 years, 3 months ago (2015-09-02 06:38:25 UTC) #3
hajimehoshi
Impressive. lgtm
5 years, 3 months ago (2015-09-02 06:39:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311913006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311913006/1
5 years, 3 months ago (2015-09-02 06:39:58 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 06:45:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201619

Powered by Google App Engine
This is Rietveld 408576698