[sqlite] Remove WebDatabase externs and depend on what you use.

[sqlite] Remove WebDatabase externs and depend on what you use.

WebDatabase used an extern "C" section to declare the monkey-patching
symbols it uses from our patched SQLite VFS code.  Switch to the items
exported from sqlite3.h.

Additionally, various modules were satisfying an implicit dependency on
icu via SQLite's static library (SQLite needs it for the REGEXP override
in sqlite/src/ext/icu/icu.c).  Change the modules depending on the
sqlite library to also depend on icu, so that sqlite can work with
component build.

BUG=489444
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201093

[Scott Hess - ex-Googler, 2015-08-24 21:23:43]

Doc the #define

[Scott Hess - ex-Googler, 2015-08-24 21:24:54]

shess@chromium.org changed reviewers:
+ michaeln@chromium.org

[Scott Hess - ex-Googler, 2015-08-24 21:24:55]

Browser-side changes which this enables:
  https://codereview.chromium.org/1312463002

CHROMIUM_SQLITE_INTERNALS is a horrible hack, but I think it's better than the
externs.

[michaeln, 2015-08-24 22:22:01]

lgtm

[Scott Hess - ex-Googler, 2015-08-24 22:29:31]

shess@chromium.org changed reviewers:
+ haraken@chromium.org

[Scott Hess - ex-Googler, 2015-08-24 22:29:31]

haraken@ OWNERS review for modules/ and core/ gyp/gn changes.

Thanks,
scott

[Scott Hess - ex-Googler, 2015-08-24 22:30:02]

The CQ bit was checked by shess@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-24 22:30:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311913002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311913002/20001

[haraken, 2015-08-24 23:23:05]

LGTM

[commit-bot: I haz the power, 2015-08-24 23:31:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-24 23:31:49]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Scott Hess - ex-Googler, 2015-08-25 00:05:07]

On 2015/08/24 23:31:49, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

"Too many open files in system"

I'm not sure how that could result from this CL, without much greater issues
being in evidence.  I'll poke a sheriff.

[Scott Hess - ex-Googler, 2015-08-25 01:55:26]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2015-08-25 01:55:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311913002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311913002/20001

[commit-bot: I haz the power, 2015-08-25 03:00:40]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201093