Adding WebRTC logging filter, handler and handler host.

content/renderer/webrtc_logging_handler_impl.cc

Index: content/renderer/webrtc_logging_handler_impl.cc
diff --git a/content/renderer/webrtc_logging_handler_impl.cc b/content/renderer/webrtc_logging_handler_impl.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1c4b68cd84cd8006d61017543bdd4943fc2e7259
--- /dev/null
+++ b/content/renderer/webrtc_logging_handler_impl.cc
@@ -0,0 +1,54 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/webrtc_logging_handler_impl.h"
+
+#include "base/logging.h"
+#include "base/message_loop_proxy.h"
+#include "content/renderer/webrtc_logging_message_filter.h"
+
+namespace content {
+
+WebRtcLoggingHandlerImpl::WebRtcLoggingHandlerImpl(
+    const scoped_refptr<WebRtcLoggingMessageFilter>& message_filter,
+    const scoped_refptr<base::MessageLoopProxy>& io_message_loop)
+    : message_filter_(message_filter),
+      io_message_loop_(io_message_loop) {
+}
+
+WebRtcLoggingHandlerImpl::~WebRtcLoggingHandlerImpl() {
+}
+
+void WebRtcLoggingHandlerImpl::OnFilterRemoved() {
+  message_filter_ = NULL;
+}
+
+void WebRtcLoggingHandlerImpl::OpenLog() {
+  if(!io_message_loop_->BelongsToCurrentThread()) {

[brettw, 2013/04/05 19:59:05]

I'm usually kind of worried when I see functions where you don't know what
thread you're on. Is there a reason you can't just assert that you're on the I/O
thread?

[Henrik Grunell, 2013/04/08 09:15:39]

This will be called from libjingle. Should libjingle be enforced to call this on
the I/O thread? (That's OK with me if it's preferred.)

[Henrik Grunell, 2013/04/12 12:23:41]

Adding reply by brettw:
"I'm definitely in favor of defining which thread libjingle will call us back
on.
I don't particularly care which thread this is, though, I'm just concerned that
the code doesn't seem to know which thread and is designed to handle "whatever."
:)"

I was mistaken, it will be called from Chromium. Changed to dcheck.

+    io_message_loop_->PostTask(
+        FROM_HERE,
+        base::Bind(&WebRtcLoggingHandlerImpl::OpenLog, this));
+  }
+  // TODO(grunell): Check if already opened. (Could have been opened by another
+  // render view.)
+  if (message_filter_)
+    message_filter_->OpenLog();
+}
+
+void WebRtcLoggingHandlerImpl::OnLogOpened(
+    base::SharedMemoryHandle handle,
+    uint32 length) {
+  DCHECK(io_message_loop_->BelongsToCurrentThread());
+  // TODO(grunell): Implement.
+  NOTIMPLEMENTED();
+}
+
+void WebRtcLoggingHandlerImpl::OnOpenLogFailed() {
+  DCHECK(io_message_loop_->BelongsToCurrentThread());
+  LOG(ERROR) << "Could not open log.";

[brettw, 2013/04/05 19:59:05]

Does this need to be non-debug logging? Since this is in the renderer you're
probably not going to see it anyway in non-debug environments due to the
sandbox.

[Henrik Grunell, 2013/04/08 09:15:39]

DLOG is fine with me. Changed.

+  // TODO(grunell): Implement.
+  NOTIMPLEMENTED();
+}
+
+}  // namespace content