Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1311893010: Specialize SkOncePtr<T[]>. (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Specialize SkOncePtr<T[]>. SkOncePtr<T[]> is identical to SkOncePtr<T> except we'll default to delete[] for cleanup. CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot BUG=skia: No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/9a50174dbc25773fe9b1b582106fb752ff38eec2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M include/core/SkColorTable.h View 1 chunk +3 lines, -5 lines 0 comments Download
M include/private/SkOncePtr.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkColorTable.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311893010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311893010/1
5 years, 3 months ago (2015-09-09 14:06:24 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-09 14:18:14 UTC) #4
mtklein
Obviously, I need to reland the previous CL first before this can land, but this ...
5 years, 3 months ago (2015-09-09 14:30:35 UTC) #6
mtklein_C
Er, maybe this will send the code review request boilerplate?
5 years, 3 months ago (2015-09-09 14:31:18 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311893010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311893010/1
5 years, 3 months ago (2015-09-09 16:43:29 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-09 16:44:02 UTC) #11
herb_g
lgtm This is very nice.
5 years, 3 months ago (2015-09-09 16:54:46 UTC) #12
herb_g
lgtm This is very nice.
5 years, 3 months ago (2015-09-09 16:54:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311893010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311893010/1
5 years, 3 months ago (2015-09-09 16:56:20 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/2510)
5 years, 3 months ago (2015-09-09 16:57:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311893010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311893010/1
5 years, 3 months ago (2015-09-09 16:59:49 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 17:00:25 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9a50174dbc25773fe9b1b582106fb752ff38eec2

Powered by Google App Engine
This is Rietveld 408576698