Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: test/checker/checker_test.dart

Issue 1311863005: Infer parameter types on overrides (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Infer on untyped default optional params as well Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/checker/resolver.dart ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/checker/checker_test.dart
diff --git a/test/checker/checker_test.dart b/test/checker/checker_test.dart
index 1a1abc134469a127564520a8f059ec5168a9d5bb..82173c4fe50ca00fc11be148498761f0159f81c4 100644
--- a/test/checker/checker_test.dart
+++ b/test/checker/checker_test.dart
@@ -1488,7 +1488,7 @@ void main() {
class Child extends Base {
void set f1(A value) {}
/*severe:InvalidMethodOverride*/void set f2(C value) {}
- /*severe:InvalidMethodOverride*/void set f3(value) {}
+ void set f3(value) {}
/*severe:InvalidMethodOverride*/void set f4(dynamic value) {}
set f5(B value) {}
}
@@ -1518,7 +1518,7 @@ void main() {
void set f1(A value) {}
/*severe:InvalidMethodOverride*/void set f2(C value) {}
- /*severe:InvalidMethodOverride*/void set f3(value) {}
+ void set f3(value) {}
/*severe:InvalidMethodOverride*/void set f4(dynamic value) {}
set f5(B value) {}
}
@@ -1547,7 +1547,7 @@ void main() {
/*severe:InvalidMethodOverride*/C m2(C value) {}
/*severe:InvalidMethodOverride*/A m3(C value) {}
C m4(A value) {}
- /*severe:InvalidMethodOverride*/m5(value) {}
+ m5(value) {}
/*severe:InvalidMethodOverride*/dynamic m6(dynamic value) {}
}
'''
@@ -2025,14 +2025,14 @@ void main() {
implements I1 {}
class T2 extends Base implements I1 {
- /*severe:InvalidMethodOverride,severe:InvalidMethodOverride*/m(a) {}
+ /*severe:InvalidMethodOverride*/m(a) {}
}
class T3 extends Object with /*severe:InvalidMethodOverride*/Base
implements I1 {}
class T4 extends Object with Base implements I1 {
- /*severe:InvalidMethodOverride,severe:InvalidMethodOverride*/m(a) {}
+ /*severe:InvalidMethodOverride*/m(a) {}
}
'''
});
« no previous file with comments | « lib/src/checker/resolver.dart ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698