Source/modules/mediastream/RTCCertificate.idl - Issue 1311853005: RTCCertificate and RTCPeerConnection.generateCertificate added to JavaScript

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/mediastream/RTCCertificate.idl

Issue 1311853005: RTCCertificate and RTCPeerConnection.generateCertificate added to JavaScript (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed guidou's comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/mediastream/RTCCertificate.cpp ('k') | Source/modules/mediastream/RTCPeerConnection.h » ('j') | Source/modules/mediastream/RTCPeerConnection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/mediastream/RTCCertificate.idl

diff --git a/Source/modules/mediastream/RTCSessionDescriptionCallback.idl b/Source/modules/mediastream/RTCCertificate.idl

similarity index 88%

copy from Source/modules/mediastream/RTCSessionDescriptionCallback.idl

copy to Source/modules/mediastream/RTCCertificate.idl

index 59ffe441a6758bedde67a1101efbb550a921affc..2863731fab40155bd9b43f244f1a262c53b613fd 100644

--- a/Source/modules/mediastream/RTCSessionDescriptionCallback.idl

+++ b/Source/modules/mediastream/RTCCertificate.idl

@@ -1,5 +1,5 @@

* Redistribution and use in source and binary forms, with or without

* modification, are permitted provided that the following conditions

@@ -28,7 +28,10 @@

* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-callback interface RTCSessionDescriptionCallback {

- void handleEvent(RTCSessionDescription sdp);

+ GarbageCollected,

+ NoInterfaceObject,

+ RuntimeEnabled=RTCCertificate

+] interface RTCCertificate {

+ readonly attribute Date expires;

jochen (gone - plz use gerrit) 2015/09/15 08:04:18 uh, I see this poor name comes from the spec :-/

hbos_chromium 2015/09/21 16:12:22 Indeed it does. Uhm, I'm not sure... notAfter is o

};