Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: Source/modules/mediastream/RTCCertificate.h

Issue 1311853005: RTCCertificate and RTCPeerConnection.generateCertificate added to JavaScript (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code cleanup, added comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/RTCCertificate.h
diff --git a/Source/core/dom/custom/CustomElementAsyncImportMicrotaskQueue.h b/Source/modules/mediastream/RTCCertificate.h
similarity index 66%
copy from Source/core/dom/custom/CustomElementAsyncImportMicrotaskQueue.h
copy to Source/modules/mediastream/RTCCertificate.h
index 09c325e1803af3841dc3b03f00c138f3b6291d87..ecbd5a21cf03e32e060e9460fc6f11988f3e7063 100644
--- a/Source/core/dom/custom/CustomElementAsyncImportMicrotaskQueue.h
+++ b/Source/modules/mediastream/RTCCertificate.h
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2014 Google Inc. All rights reserved.
+ * Copyright (C) 2015 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -28,24 +28,36 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef CustomElementAsyncImportMicrotaskQueue_h
-#define CustomElementAsyncImportMicrotaskQueue_h
+#ifndef RTCCertificate_h
+#define RTCCertificate_h
-#include "core/dom/custom/CustomElementMicrotaskQueueBase.h"
+#include "bindings/core/v8/ScriptWrappable.h"
+#include "platform/heap/GarbageCollected.h"
+#include "public/platform/WebRTCCertificate.h"
namespace blink {
-class CustomElementAsyncImportMicrotaskQueue : public CustomElementMicrotaskQueueBase {
+class RTCCertificate final : public GarbageCollectedFinalized<RTCCertificate>, public ScriptWrappable {
+ DEFINE_WRAPPERTYPEINFO();
public:
- static PassRefPtrWillBeRawPtr<CustomElementAsyncImportMicrotaskQueue> create() { return adoptRefWillBeNoop(new CustomElementAsyncImportMicrotaskQueue()); }
+ // Visible to the JavaScript world in accordance with the .idl file:
- void enqueue(PassOwnPtrWillBeRawPtr<CustomElementMicrotaskStep>);
+ double expires() const;
hbos_chromium 2015/09/02 13:00:33 Is this the correct return type for Date in JavaSc
Guido Urdaneta 2015/09/03 11:07:49 Based on other uses of Date in blink, double is th
hbos_chromium 2015/09/03 16:01:37 Acknowledged.
+
+ // Hidden from the JavaScript world:
+
+ // Takes ownership of |certificate|.
+ RTCCertificate(WebRTCCertificate* /*certificate*/);
+ ~RTCCertificate() override;
+
+ const WebRTCCertificate* certificate() const;
+
+ DEFINE_INLINE_TRACE() {}
private:
- CustomElementAsyncImportMicrotaskQueue() { }
- void doDispatch() override;
+ WebRTCCertificate* m_certificate;
hbos_chromium 2015/09/02 13:00:33 Equivalent of rtc::scoped_ptr?
Guido Urdaneta 2015/09/03 11:07:49 Use OwnPtr. Instructions on how to use it are here
hbos_chromium 2015/09/03 16:01:37 Done. Thanks for the link, I was confused about Ow
};
} // namespace blink
-#endif // CustomElementAsyncImportMicrotaskQueue_h
+#endif // RTCCertificate_h
« no previous file with comments | « no previous file | Source/modules/mediastream/RTCCertificate.cpp » ('j') | Source/modules/mediastream/RTCCertificate.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698