RTCCertificate and RTCPeerConnection.generateCertificate added to JavaScript

Source/modules/mediastream/RTCPeerConnection.idl

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 30 matching lines @@
     [RaisesException] void createAnswer(RTCSessionDescriptionCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback, optional Dictionary mediaConstraints);
 
     [RaisesException] void setLocalDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
     [RaisesException=Getter] readonly attribute RTCSessionDescription localDescription;
 
     [RaisesException] void setRemoteDescription(RTCSessionDescription description, [Default=Undefined] optional VoidCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback);
     [RaisesException=Getter] readonly attribute RTCSessionDescription remoteDescription;
 
     readonly attribute DOMString signalingState;
 
+    // FIXME: Latest WebRTC specifications renames this to setConfiguration
     [RaisesException] void updateIce(optional Dictionary configuration, optional Dictionary mediaConstraints);
 
+    [RuntimeEnabled=RTCCertificate, RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> generateCertificate(Dictionary keygenAlgorithm);

[jochen (gone - plz use gerrit), 2015/09/15 08:04:19]

this should be AlgorithmIdentifier, not Dictionary, no?

[hbos_chromium, 2015/09/21 16:12:22]

You're right. It should be a WebCryptoAPI AlgorithmIdentifier, which is an
object (Dictionary) or DOMString that is parsed. I took a look at this after
your comment.

Currently I'm doing the parsing myself. What I should be using is the
WebCryptoAPI normalization process which parses it for us. I tried to do this,
but I believe I've found a WebCryptoAPI bug. If I try to parse what the WebRTC
spec says must be supported, normalizeAlgorithm() complains that the
publicExponent parameter is not an Uint8Array. I have filed a bug
(crbug.com/534416) with rsleevi@ CC'd.

In the meantime I've added a TODO.

+
     // DEPRECATED
     [RaisesException] void addIceCandidate(RTCIceCandidate candidate);
 
     [RaisesException] void addIceCandidate(RTCIceCandidate candidate, VoidCallback successCallback, RTCErrorCallback failureCallback);
 
     readonly attribute DOMString iceGatheringState;
     readonly attribute DOMString iceConnectionState;
 
     sequence<MediaStream> getLocalStreams();
     sequence<MediaStream> getRemoteStreams();
@@ skipping 11 matching lines @@
     [RaisesException] void close();
 
     attribute EventHandler onnegotiationneeded;
     attribute EventHandler onicecandidate;
     attribute EventHandler onsignalingstatechange;
     attribute EventHandler onaddstream;
     attribute EventHandler onremovestream;
     attribute EventHandler oniceconnectionstatechange;
     attribute EventHandler ondatachannel;
 };