RTCCertificate and RTCPeerConnection.generateCertificate added to JavaScript

Source/platform/mediastream/RTCConfiguration.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef RTCConfiguration_h
 #define RTCConfiguration_h
 
 #include "platform/heap/Handle.h"
 #include "platform/weborigin/KURL.h"
+#include "public/platform/WebRTCCertificate.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/Vector.h"
 #include "wtf/text/WTFString.h"
 
+#include <vector>
+
 namespace blink {
 
 class RTCIceServer final : public GarbageCollectedFinalized<RTCIceServer> {
 public:
     static RTCIceServer* create(const KURL& uri, const String& username, const String& credential)
     {
         return new RTCIceServer(uri, username, credential);
     }
 
     const KURL& uri() { return m_uri; }
@@ skipping 25 matching lines @@
     RTCBundlePolicyBalanced,
     RTCBundlePolicyMaxCompat,
     RTCBundlePolicyMaxBundle
 };
 
 enum RTCRtcpMuxPolicy {
     RTCRtcpMuxPolicyNegotiate,
     RTCRtcpMuxPolicyRequire
 };
 
-class RTCConfiguration final : public GarbageCollected<RTCConfiguration> {
+class RTCConfiguration final : public GarbageCollectedFinalized<RTCConfiguration> {
 public:
     static RTCConfiguration* create() { return new RTCConfiguration(); }
 
+    ~RTCConfiguration()

[Guido Urdaneta, 2015/09/03 11:07:49]

Implement this in the .cpp

[hbos_chromium, 2015/09/03 16:01:37]

I'm having trouble compiling after adding a .cpp file (cannot link
libmodules.so)... I'll address this later before landing this CL.

+    {
+        for (WebRTCCertificate* certificate : m_certificates)
+            delete certificate;
+    }
+
     void appendServer(RTCIceServer* server) { m_servers.append(server); }
     size_t numberOfServers() { return m_servers.size(); }
     RTCIceServer* server(size_t index) { return m_servers[index].get(); }
     void setIceTransports(RTCIceTransports iceTransports) { m_iceTransports = iceTransports; }
     RTCIceTransports iceTransports() { return m_iceTransports; }
     void setBundlePolicy(RTCBundlePolicy bundlePolicy) { m_bundlePolicy = bundlePolicy; }
     RTCBundlePolicy bundlePolicy() { return m_bundlePolicy; }
     void setRtcpMuxPolicy(RTCRtcpMuxPolicy rtcpMuxPolicy) { m_rtcpMuxPolicy = rtcpMuxPolicy; }
     RTCRtcpMuxPolicy rtcpMuxPolicy() { return m_rtcpMuxPolicy; }
+    void appendCertificate(WebRTCCertificate* certificate) { m_certificates.push_back(certificate); }
+    size_t numberOfCertificates() const { return m_certificates.size(); }
+    WebRTCCertificate* certificate(size_t index) const { return m_certificates[index]; }
 
     DEFINE_INLINE_TRACE() { visitor->trace(m_servers); }
 
 private:
     RTCConfiguration() :
         m_iceTransports(RTCIceTransportsAll),
         m_bundlePolicy(RTCBundlePolicyBalanced),
         m_rtcpMuxPolicy(RTCRtcpMuxPolicyNegotiate) { }
 
     HeapVector<Member<RTCIceServer>> m_servers;
     RTCIceTransports m_iceTransports;
     RTCBundlePolicy m_bundlePolicy;
     RTCRtcpMuxPolicy m_rtcpMuxPolicy;
+    std::vector<WebRTCCertificate*> m_certificates;

[Guido Urdaneta, 2015/09/03 11:07:49]

Apparently Vector is preferred to std::vector in blink.

[hbos_chromium, 2015/09/03 16:01:37]

Done.

 };
 
 } // namespace blink
 
 #endif // RTCConfiguration_h