RTCCertificate and RTCPeerConnection.generateCertificate added to JavaScript

public/platform/WebRTCKeyType.h

 /*
  * Copyright (C) 2015 Google Inc. All rights reserved.
- * Copyright (C) 2015 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
  * copyright notice, this list of conditions and the following disclaimer
  * in the documentation and/or other materials provided with the
  * distribution.
  *     * Neither the name of Google Inc. nor the names of its
  * contributors may be used to endorse or promote products derived from
  * this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef PerformanceCompositeTiming_h
-#define PerformanceCompositeTiming_h
-
-#include "core/timing/PerformanceEntry.h"
-#include "platform/heap/Handle.h"
-#include "wtf/Forward.h"
-#include "wtf/text/WTFString.h"
+#ifndef WebRTCKeyType_h
+#define WebRTCKeyType_h
 
 namespace blink {
 
-class Document;
+// Corresponds to KeyTypeFamily in webrtc.
+enum WebRTCKeyFamily { KeyFamilyRsa, KeyFamilyEcdsa, KeyFamilyLast };

[jochen (gone - plz use gerrit), 2015/09/22 15:48:53]

enum values should start with the enum's name, i.e. WebRTCKeyFamilyRsa, etc..

[hbos_chromium, 2015/09/28 08:10:16]

Done.

 
-class PerformanceCompositeTiming final : public PerformanceEntry {
-    DEFINE_WRAPPERTYPEINFO();
+// Corresponds to KeyType in webrtc.
+class WebRTCKeyType {
 public:
-    static PerformanceCompositeTiming* create(Document* requestingDocument, unsigned sourceFrame, double startTime)
+    static WebRTCKeyType createRSA(int modulusLength = 1024)

[jochen (gone - plz use gerrit), 2015/09/22 15:48:53]

what's a negative modules? also, do we really need a default value here? and why
such a low length as default?

[hbos_chromium, 2015/09/28 08:10:16]

Added a BLINK_ASSERT sanity check. Removed default value (previously used 1024
because that is what generation code inside of webrtc has been using).

     {
-        return new PerformanceCompositeTiming(requestingDocument, sourceFrame, startTime);
+        return WebRTCKeyType(KeyFamilyRsa, modulusLength);
+    }
+    static WebRTCKeyType createECDSA()
+    {
+        return WebRTCKeyType(KeyFamilyEcdsa);
     }
 
-    unsigned sourceFrame() const;
+    explicit WebRTCKeyType(WebRTCKeyFamily family = KeyFamilyRsa)

[jochen (gone - plz use gerrit), 2015/09/22 15:48:53]

if you have factory methods, the ctor should be private, no?

[hbos_chromium, 2015/09/28 08:10:16]

Need a public default constructor if I want to use Nullable<WebRTCKeyType>
without setting a value. I introduced WebRTCKeyFamilyNull instead and made the
default constructor construct that.

I use Nullable<WebRTCKeyType> in RTCPeerConnection::generateCertificate. If you
don't like this I can get around that.

+        : WebRTCKeyType(family, family == KeyFamilyRsa ? 1024 : 0) {}
 
-    DECLARE_VIRTUAL_TRACE();
+    WebRTCKeyFamily family() const { return m_family; }
 
 private:
-    PerformanceCompositeTiming(Document* requestingDocument, unsigned sourceFrame, double startTime);
-    ~PerformanceCompositeTiming() override;
+    WebRTCKeyType(WebRTCKeyFamily family, int parameter)
+        : m_family(family), m_parameter(parameter) {}
 
-    unsigned m_sourceFrame;
-    RefPtrWillBeMember<Document> m_requestingDocument;
+    WebRTCKeyFamily m_family;
+    // For RSA: modulusLength.
+    // For ECDSA: N/A (curve id in the future).
+    int m_parameter;

[jochen (gone - plz use gerrit), 2015/09/22 15:48:53]

why do you store this, there's no getter for this

[hbos_chromium, 2015/09/28 08:10:16]

Added getter. It will be used to convert from blink::WebRTCKeyType to
rtc::KeyType when KeyType has become parameterized.

 };
 
 } // namespace blink
 
-#endif // PerformanceCompositeTiming_h
+#endif // WebRTCKeyType_h