Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: Source/core/editing/VisiblePosition.h

Issue 1311853004: Rename visiblePositionOf() to createVisiblePosition() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-01T14:43:58 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/SelectionController.cpp ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisiblePosition.h
diff --git a/Source/core/editing/VisiblePosition.h b/Source/core/editing/VisiblePosition.h
index 3ad7a208dbbc0d6622e64b4493a66a974b0be552..e967a136abe89490f249708f942fc8156f98dea4 100644
--- a/Source/core/editing/VisiblePosition.h
+++ b/Source/core/editing/VisiblePosition.h
@@ -72,12 +72,12 @@ class CORE_EXPORT VisiblePosition final {
public:
VisiblePosition() : m_affinity(VP_DEFAULT_AFFINITY) { }
- // TODO(yosin) We should use |visiblePositionOf()| instead of constructor,
- // and make constructors to have private accessibility, since constructors
- // aren't simple, e.g. they update layout tree.
+ // TODO(yosin) We should use |createVisiblePosition()| instead of
+ // constructor, and make constructors to have private accessibility, since
+ // constructors aren't simple, e.g. they update layout tree.
explicit VisiblePosition(const Position&, TextAffinity = VP_DEFAULT_AFFINITY);
- // Node: Other than |visiblePositionOf()|, we should not use
+ // Node: Other than |createVisiblePosition()|, we should not use
// |createWithoutCanonicalization()|.
static VisiblePosition createWithoutCanonicalization(const PositionWithAffinity& canonicalized);
@@ -139,9 +139,9 @@ PositionWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionWithAffinity
PositionInComposedTreeWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionInComposedTreeWithAffinity&, const PositionInComposedTree& anchor);
VisiblePosition honorEditingBoundaryAtOrAfter(const VisiblePosition&, const Position& anchor);
-CORE_EXPORT VisiblePosition visiblePositionOf(const Position&, TextAffinity = VP_DEFAULT_AFFINITY);
-CORE_EXPORT VisiblePosition visiblePositionOf(const PositionWithAffinity&);
-CORE_EXPORT VisiblePosition visiblePositionOf(const PositionInComposedTree&, TextAffinity = VP_DEFAULT_AFFINITY);
+CORE_EXPORT VisiblePosition createVisiblePosition(const Position&, TextAffinity = VP_DEFAULT_AFFINITY);
+CORE_EXPORT VisiblePosition createVisiblePosition(const PositionWithAffinity&);
+CORE_EXPORT VisiblePosition createVisiblePosition(const PositionInComposedTree&, TextAffinity = VP_DEFAULT_AFFINITY);
} // namespace blink
« no previous file with comments | « Source/core/editing/SelectionController.cpp ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698