Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 1311853004: Rename visiblePositionOf() to createVisiblePosition() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-01T14:43:58 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/DragCaretController.cpp ('k') | Source/core/editing/SelectionController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index a2077e0fb317dfb0865febf50ff84f3b6299d0a9..9c7ddf37b785eb250b2df627f053531ef7185dd1 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -202,9 +202,9 @@ void FrameSelection::setNonDirectionalSelectionIfNeededAlgorithm(const VisibleSe
VisibleSelection newSelection = passedNewSelection;
bool isDirectional = shouldAlwaysUseDirectionalSelection(m_frame) || newSelection.isDirectional();
- VisiblePosition base = m_originalBase.isNotNull() ? m_originalBase : visiblePositionOf(Strategy::selectionBase(newSelection));
+ VisiblePosition base = m_originalBase.isNotNull() ? m_originalBase : createVisiblePosition(Strategy::selectionBase(newSelection));
VisiblePosition newBase = base;
- VisiblePosition extent = visiblePositionOf(Strategy::selectionExtent(newSelection));
+ VisiblePosition extent = createVisiblePosition(Strategy::selectionExtent(newSelection));
VisiblePosition newExtent = extent;
if (endpointsAdjustmentMode == AdjustEndpointsAtBidiBoundary)
adjustEndpointsAtBidiBoundary(newBase, newExtent);
@@ -1364,7 +1364,7 @@ bool FrameSelection::containsAlgorithm(const LayoutPoint& point)
if (!innerNode || !innerNode->layoutObject())
return false;
- VisiblePosition visiblePos = visiblePositionOf(innerNode->layoutObject()->positionForPoint(result.localPoint()));
+ VisiblePosition visiblePos = createVisiblePosition(innerNode->layoutObject()->positionForPoint(result.localPoint()));
if (visiblePos.isNull())
return false;
« no previous file with comments | « Source/core/editing/DragCaretController.cpp ('k') | Source/core/editing/SelectionController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698