Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1311853002: Update PushEvent and PushMessageData to match the spec. (Closed)

Created:
5 years, 4 months ago by Peter Beverloo
Modified:
5 years, 4 months ago
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, johnme+watch_chromium.org, peter+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update PushEvent and PushMessageData to match the spec. The specification defines that PushEvents can be initialized with a data member that is of type PushMessageDataInit, rather than an actual PushMessageData object. This allows us to remove the constructor from the PushMessageData object entirely, aligning with the specification. https://w3c.github.io/push-api/#pushmessagedata-interface This CL also implements the following pull requests, which defines the PushMessageDataInit type to also encapsulate ArrayBuffer(View)?. https://github.com/w3c/push-api/pull/160 Note that the PushMessageData object has not shipped to the world yet. R=mvanouwerkerk BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201129

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -136 lines) Patch
A LayoutTests/http/tests/push_messaging/pushmessagedata.html View 1 chunk +19 lines, -0 lines 0 comments Download
D LayoutTests/http/tests/push_messaging/pushmessagedata-constructor-text.html View 1 chunk +0 lines, -18 lines 0 comments Download
M LayoutTests/http/tests/push_messaging/resources/interfaces-worker.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/push_messaging/resources/pushevent-extendable-event.js View 1 chunk +4 lines, -3 lines 0 comments Download
D LayoutTests/http/tests/push_messaging/resources/pushmessagedata-constructor-text.js View 1 chunk +0 lines, -93 lines 0 comments Download
A LayoutTests/http/tests/push_messaging/resources/pushmessagedata-worker.js View 1 chunk +127 lines, -0 lines 0 comments Download
M Source/modules/push_messaging/PushEvent.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/push_messaging/PushEvent.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/modules/push_messaging/PushEventInit.idl View 1 chunk +4 lines, -1 line 0 comments Download
M Source/modules/push_messaging/PushMessageData.h View 2 chunks +7 lines, -8 lines 0 comments Download
M Source/modules/push_messaging/PushMessageData.cpp View 4 chunks +35 lines, -9 lines 0 comments Download
M Source/modules/push_messaging/PushMessageData.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Peter Beverloo
PTAL
5 years, 4 months ago (2015-08-24 17:23:35 UTC) #1
Michael van Ouwerkerk
lgtm Thanks!
5 years, 4 months ago (2015-08-25 11:11:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311853002/1
5 years, 4 months ago (2015-08-25 12:04:20 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 12:59:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201129

Powered by Google App Engine
This is Rietveld 408576698