[Password Manager] Implement ShouldShowMultipleAccountUpdateUI in ManagePasswordUIController

[Password Manager] Implement ShouldShowMultipleAccountUpdateUI in ManagePasswordUIController

In order to re use ShouldShowMultipleAccountUpdateUI on Clank we need to
implement in ManagePasswordUIController instead of ManagePasswordsBubbleMode.

BUG=359315
R=dvadym@chromium.org

Committed: https://crrev.com/ffd0821d720e641bce612a25455e9e0a16c82909
Cr-Commit-Position: refs/heads/master@{#345717}

[melandory, 2015-08-25 09:57:27]

Patchset #1 (id:1) has been deleted

[melandory, 2015-08-25 11:24:18]

Hi Vadym,

please take a look. I'm especially interested if default value false in
ManagePasswordsBubbleModel::ShouldShowMultipleAccountUpdateUI
makes sense.

Thanks in advance!

[dvadym, 2015-08-25 13:55:24]

LGTM with nits (but I'm not an owner of these files).

https://codereview.chromium.org/1311833004/diff/20001/chrome/browser/ui/passw...
File chrome/browser/ui/passwords/manage_passwords_bubble_model.cc (right):

https://codereview.chromium.org/1311833004/diff/20001/chrome/browser/ui/passw...
chrome/browser/ui/passwords/manage_passwords_bubble_model.cc:349: if
(controller)
You can skip checking if controller is valid as it's done in
ManagePasswordsBubbleModel::OnBubbleShown.

[vabr (Chromium), 2015-08-26 08:57:43]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2015-08-26 08:57:43]

Rubberstamp LGTM (=change looks good, please make sure to address Vadym's
comment).

Cheers,
Vaclav

[melandory, 2015-08-26 12:38:26]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-26 12:38:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311833004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311833004/40001

[commit-bot: I haz the power, 2015-08-26 13:31:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 13:31:51]

Dry run: This issue passed the CQ dry run.

[melandory, 2015-08-26 23:12:14]

The CQ bit was checked by melandory@chromium.org

[melandory, 2015-08-26 23:12:15]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
dvadym@chromium.org
Link to the patchset: https://codereview.chromium.org/1311833004/#ps40001
(title: "Remove check")

[commit-bot: I haz the power, 2015-08-26 23:12:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311833004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311833004/40001

[commit-bot: I haz the power, 2015-08-26 23:19:21]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-08-26 23:20:00]

Patchset 2 (id:??) landed as
https://crrev.com/ffd0821d720e641bce612a25455e9e0a16c82909
Cr-Commit-Position: refs/heads/master@{#345717}