Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1311813005: Revert of [turbofan] greedy: heuristic for memory operands (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] greedy: heuristic for memory operands (patchset #2 id:40001 of https://codereview.chromium.org/1306823005/ ) Reason for revert: [Sheriff] Breaks test with greedy allocator: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20greedy%20allocator/builds/1318 Original issue's description: > [turbofan] greedy: heuristic for memory operands > > When we have a memory operand (HasSpillOperand() == true), and it > doesn't need a register immediately, split in an optimal position, which > is outside the outermost possible loop - just like Linear does. > > This results in some modest improvements in perf, when compared > to baseline greedy. In particular Jetstream zlib x64: 4.66%, Life > (Emscripten x64) 11%; largest regression is in AreWeFastYet x64: 8% > and Corrections (Emsccripten x32) 10% > > BUG= > > Committed: https://crrev.com/8937bfc1d165ff6d72dede1b0ce6f7c1ab9fb260 > Cr-Commit-Position: refs/heads/master@{#30498} TBR=jarin@chromium.org,bmeurer@chromium.org,mtrofin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/f68cd33bdd342819abd5b091591ac78383c2e79d Cr-Commit-Position: refs/heads/master@{#30501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/compiler/greedy-allocator.cc View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [turbofan] greedy: heuristic for memory operands
5 years, 3 months ago (2015-09-01 09:37:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311813005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311813005/1
5 years, 3 months ago (2015-09-01 09:37:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 09:37:28 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 09:37:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f68cd33bdd342819abd5b091591ac78383c2e79d
Cr-Commit-Position: refs/heads/master@{#30501}

Powered by Google App Engine
This is Rietveld 408576698