Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 1311803004: Introduce composed tree version of rightPositionOf() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce composed tree version of rightPositionOf() This patch introduces composed tree version of |rightPositionOf()| by templatizing original |rightPositionOf()| to work both DOM tree position and composed tree position version for introducing composed tree version of |VisibleSelection| class. This patch also templaizes |rightVisuallyDistinctCandidate()| used by |rightPositionOf()|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201967

Patch Set 1 : 2015-09-09T15:57:15 #

Patch Set 2 : 2015-09-09T17:18:38 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -17 lines) Patch
M Source/core/editing/VisibleUnits.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 5 chunks +27 lines, -16 lines 0 comments Download
M Source/core/editing/VisibleUnitsTest.cpp View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
yosin_UTC9
PTAL It seems ios_rel_device_ninja and ios_dbg_simulator_ninja are broken. They don't have the latest VisibleUnits.cpp.
5 years, 3 months ago (2015-09-09 07:21:17 UTC) #2
hajimehoshi
lgtm
5 years, 3 months ago (2015-09-09 07:27:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311803004/1
5 years, 3 months ago (2015-09-09 07:31:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/66977) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-09 07:33:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311803004/20001
5 years, 3 months ago (2015-09-09 08:19:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/66993) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-09 08:22:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311803004/20001
5 years, 3 months ago (2015-09-09 08:56:57 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/67006)
5 years, 3 months ago (2015-09-09 08:59:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311803004/20001
5 years, 3 months ago (2015-09-09 09:24:22 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/109081)
5 years, 3 months ago (2015-09-09 09:26:34 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311803004/20001
5 years, 3 months ago (2015-09-09 10:37:35 UTC) #22
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 10:42:00 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201967

Powered by Google App Engine
This is Rietveld 408576698