Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311783009: Fix bug in CSSCursorImageValue::equals() (Closed)

Created:
5 years, 4 months ago by sashab
Modified:
5 years, 3 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix bug in CSSCursorImageValue::equals() Fixed a bug in CSSCursorImageValue::equals() which was causing any cursor images with the same hotspot to be treated as equal. Also added a test. BUG=510188 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201288

Patch Set 1 #

Total comments: 2

Patch Set 2 : Simplified test #

Patch Set 3 : Removed unrelated whitespace change #

Patch Set 4 : Localized cursor URL to fix httpd errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
A LayoutTests/fast/css/bug523527-cursor-doesnt-update-with-same-hotspot.html View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/css/CSSCursorImageValue.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
sashab
5 years, 4 months ago (2015-08-26 06:50:25 UTC) #2
Timothy Loh
lgtm https://codereview.chromium.org/1311783009/diff/1/LayoutTests/fast/css/bug523527-cursor-doesnt-update-with-same-hotspot.html File LayoutTests/fast/css/bug523527-cursor-doesnt-update-with-same-hotspot.html (right): https://codereview.chromium.org/1311783009/diff/1/LayoutTests/fast/css/bug523527-cursor-doesnt-update-with-same-hotspot.html#newcode7 LayoutTests/fast/css/bug523527-cursor-doesnt-update-with-same-hotspot.html:7: var verticalCursor = "url(data:image/x-icon;base64,AAACAAEADhIAAAgACQBYBAAAFgAAACgAAAAOAAAAJAAAAAEAIAAAAAAAMAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA/wAAAP8AAAD/AAAAAAAAAP8AAAD/AAAA/wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA/wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA/wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA/wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA/wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA/wAAAP8AAAD/AAAAAAAAAP8AAAD/AAAA/wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=) 11 11, default"; Can ...
5 years, 4 months ago (2015-08-26 07:25:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311783009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311783009/40001
5 years, 3 months ago (2015-08-27 01:40:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/104296)
5 years, 3 months ago (2015-08-27 02:35:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311783009/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311783009/60001
5 years, 3 months ago (2015-08-27 03:13:06 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 05:28:55 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201288

Powered by Google App Engine
This is Rietveld 408576698