refactor to Introduce AUDIO_CAPTURE and VIDEO_CAPTURE permissions.

chrome/browser/permissions/permission_context_uma_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_context_uma_util.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/permissions/permission_manager.h"
@@ skipping 187 matching lines @@
     case PermissionType::NOTIFICATIONS:
       return "Notifications";
     case PermissionType::GEOLOCATION:
       return "Geolocation";
     case PermissionType::PROTECTED_MEDIA_IDENTIFIER:
       return "ProtectedMediaIdentifier";
     case PermissionType::DURABLE_STORAGE:
       return "DurableStorage";
     case PermissionType::MIDI:
       return "Midi";
+    case PermissionType::AUDIO_CAPTURE:
+      return "AudioRecording";
+    case PermissionType::VIDEO_CAPTURE:
+      return "VideoRecording";
     case PermissionType::NUM:
       break;
   }
   NOTREACHED();

[palmer, 2015/09/01 18:31:04]

This should be the default: clause of the switch. The entire function is then a
switch statement.

[guoweis_left_chromium, 2015/09/01 19:36:34]

It's intended to be without default so compiler can fail when a new enum is
added here.

   return std::string();
 }
 
 void RecordPermissionRequest(ContentSettingsType permission,
                              const GURL& requesting_origin,
                              const GURL& embedding_origin,
                              Profile* profile) {
   bool secure_origin = content::IsOriginSecure(requesting_origin);
   PermissionType type;
   switch (permission) {
@@ skipping 95 matching lines @@
 
 void PermissionContextUmaUtil::PermissionDismissed(
     ContentSettingsType permission, const GURL& requesting_origin) {
   RecordPermissionAction(permission, DISMISSED, requesting_origin);
 }
 
 void PermissionContextUmaUtil::PermissionIgnored(
     ContentSettingsType permission, const GURL& requesting_origin) {
   RecordPermissionAction(permission, IGNORED, requesting_origin);
 }