refactor to Introduce AUDIO_CAPTURE and VIDEO_CAPTURE permissions.

android_webview/browser/aw_permission_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_permission_manager.h"
 
 #include <string>
 
 #include "android_webview/browser/aw_browser_permission_request_delegate.h"
 #include "base/callback.h"
@@ skipping 190 matching lines @@
           origin, base::Bind(&CallbackPermisisonStatusWrapper,
                              result_cache_->GetWeakPtr(), callback, permission,
                              origin, embedding_origin));
       break;
     case PermissionType::MIDI_SYSEX:
       delegate->RequestMIDISysexPermission(
           origin, base::Bind(&CallbackPermisisonStatusWrapper,
                              result_cache_->GetWeakPtr(), callback, permission,
                              origin, embedding_origin));
       break;
+    case PermissionType::AUDIO_RECORDING:

[xhwang, 2015/08/27 19:25:17]

It seems to me that

AUDIO_RECORDING == MIC
VIDEO_RECORDING == CAMERA

Why do we use two different sets of names here? It'd be easier to read/remember
if we use consistent names across layers. Also, all other permission types are
using consistent names.

+    case PermissionType::VIDEO_RECORDING:
     case PermissionType::NOTIFICATIONS:
     case PermissionType::PUSH_MESSAGING:
     case PermissionType::DURABLE_STORAGE:
       NOTIMPLEMENTED() << "RequestPermission is not implemented for "
                        << static_cast<int>(permission);
       callback.Run(content::PERMISSION_STATUS_DENIED);
       break;
     case PermissionType::MIDI:
       callback.Run(content::PERMISSION_STATUS_GRANTED);
       break;
@@ skipping 31 matching lines @@
       break;
     case PermissionType::PROTECTED_MEDIA_IDENTIFIER:
       delegate->CancelProtectedMediaIdentifierPermissionRequests(origin);
       break;
     case PermissionType::MIDI_SYSEX:
       delegate->CancelMIDISysexPermissionRequests(origin);
       break;
     case PermissionType::NOTIFICATIONS:
     case PermissionType::PUSH_MESSAGING:
     case PermissionType::DURABLE_STORAGE:
+    case PermissionType::AUDIO_RECORDING:
+    case PermissionType::VIDEO_RECORDING:
       NOTIMPLEMENTED() << "CancelPermission not implemented for "
                        << static_cast<int>(permission);
       break;
     case PermissionType::MIDI:
       // There is nothing to cancel so this is simply ignored.
       break;
     case PermissionType::NUM:
       NOTREACHED() << "PermissionType::NUM was not expected here.";
       break;
   }
@@ skipping 32 matching lines @@
     const GURL& embedding_origin,
     const base::Callback<void(PermissionStatus)>& callback) {
   return -1;
 }
 
 void AwPermissionManager::UnsubscribePermissionStatusChange(
     int subscription_id) {
 }
 
 }  // namespace android_webview