Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 1311783004: Explicitly friend ::SkPrivateEffectInitializer to flattenables. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
Nico
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Explicitly friend ::SkPrivateEffectInitializer to flattenables. Looks like the -Wmicrosoft warnings in the bug are coming up specificically because many the effects in SkLightingImageFilter are defined inside an anonymous namespace (spanning, I think, lines 33-702 today). BUG=skia:4091 No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/ab374cf894f136418ad573dfb5da4fcb48f47db0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M include/core/SkFlattenable.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311783004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311783004/1
5 years, 4 months ago (2015-08-24 18:24:48 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-24 18:29:50 UTC) #4
mtklein_C
Agreed that it looks simplest to fix by declaring SkPrivateEffectInitializer and friending ::that.
5 years, 4 months ago (2015-08-24 18:30:38 UTC) #6
Nico
lgtm, thanks!
5 years, 4 months ago (2015-08-24 18:36:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311783004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311783004/1
5 years, 4 months ago (2015-08-24 19:32:53 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 19:33:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ab374cf894f136418ad573dfb5da4fcb48f47db0

Powered by Google App Engine
This is Rietveld 408576698