Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: Source/core/inspector/LayoutEditor.h

Issue 1311783003: Devtools[LayoutEditor]: Rework layout-editor workflow (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@resize
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/LayoutEditor.h
diff --git a/Source/core/inspector/LayoutEditor.h b/Source/core/inspector/LayoutEditor.h
index dcf5c7063171a34108b03af4955a6639d580fb3f..d8c5a46b4390126f1b3122047ee20ef4bd1dc551 100644
--- a/Source/core/inspector/LayoutEditor.h
+++ b/Source/core/inspector/LayoutEditor.h
@@ -19,15 +19,16 @@ namespace blink {
class CSSPrimitiveValue;
class InspectorCSSAgent;
+class InspectorDOMAgent;
class JSONArray;
class JSONObject;
class CORE_EXPORT LayoutEditor final: public NoBaseWillBeGarbageCollectedFinalized<LayoutEditor>, public InspectorOverlayHost::LayoutEditorListener {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(LayoutEditor);
public:
- static PassOwnPtrWillBeRawPtr<LayoutEditor> create(InspectorCSSAgent* cssAgent)
+ static PassOwnPtrWillBeRawPtr<LayoutEditor> create(InspectorCSSAgent* cssAgent, InspectorDOMAgent* domAgent)
{
- return adoptPtrWillBeNoop(new LayoutEditor(cssAgent));
+ return adoptPtrWillBeNoop(new LayoutEditor(cssAgent, domAgent));
}
void setNode(Node*);
@@ -36,7 +37,7 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- explicit LayoutEditor(InspectorCSSAgent*);
+ LayoutEditor(InspectorCSSAgent*, InspectorDOMAgent*);
RefPtrWillBeRawPtr<CSSPrimitiveValue> getPropertyCSSValue(CSSPropertyID) const;
PassRefPtr<JSONObject> createValueDescription(const String&) const;
void appendAnchorFor(JSONArray*, const String&, const String&, const FloatPoint&, const FloatPoint&) const;
@@ -45,13 +46,16 @@ private:
void overlayStartedPropertyChange(const String&) override;
void overlayPropertyChanged(float) override;
void overlayEndedPropertyChange() override;
+ void clearSelection(bool) override;
RefPtrWillBeMember<Element> m_element;
RawPtrWillBeMember<InspectorCSSAgent> m_cssAgent;
+ RawPtrWillBeMember<InspectorDOMAgent> m_domAgent;
CSSPropertyID m_changingProperty;
float m_propertyInitialValue;
float m_factor;
CSSPrimitiveValue::UnitType m_valueUnitType;
+ bool m_madeChanges;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698