Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 1311783003: Devtools[LayoutEditor]: Rework layout-editor workflow (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@resize
Patch Set: Address comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.h ('k') | Source/core/inspector/InspectorHighlight.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDOMAgent.cpp
diff --git a/Source/core/inspector/InspectorDOMAgent.cpp b/Source/core/inspector/InspectorDOMAgent.cpp
index e8f45fc6048416210542bc9c2d095d841e5d674c..6863c2a9accd0e3f28431fe8b19045911c63ca50 100644
--- a/Source/core/inspector/InspectorDOMAgent.cpp
+++ b/Source/core/inspector/InspectorDOMAgent.cpp
@@ -1091,7 +1091,6 @@ void InspectorDOMAgent::discardSearchResults(ErrorString*, const String& searchI
m_searchResults.remove(searchId);
}
-
void InspectorDOMAgent::inspect(Node* inspectedNode)
{
if (!inspectedNode)
@@ -1112,7 +1111,6 @@ void InspectorDOMAgent::inspect(Node* inspectedNode)
frontend()->inspectNodeRequested(backendNodeId);
}
-
void InspectorDOMAgent::setSearchingForNode(ErrorString* errorString, SearchMode searchMode, JSONObject* highlightInspectorObject)
{
if (m_client)
@@ -1136,9 +1134,6 @@ PassOwnPtr<InspectorHighlightConfig> InspectorDOMAgent::highlightConfigFromInspe
bool showExtensionLines = false; // Default: false (do not show extension lines).
highlightInspectorObject->getBoolean("showExtensionLines", &showExtensionLines);
highlightConfig->showExtensionLines = showExtensionLines;
- bool showLayoutEditor = false;
- highlightInspectorObject->getBoolean("showLayoutEditor", &showLayoutEditor);
- highlightConfig->showLayoutEditor = showLayoutEditor;
bool displayAsMaterial = false;
highlightInspectorObject->getBoolean("displayAsMaterial", &displayAsMaterial);
highlightConfig->displayAsMaterial = displayAsMaterial;
@@ -1163,6 +1158,8 @@ void InspectorDOMAgent::setInspectMode(ErrorString* errorString, const String& m
searchMode = SearchingForUAShadow;
} else if (mode == TypeBuilder::getEnumConstantValue(TypeBuilder::DOM::InspectMode::None)) {
searchMode = NotSearching;
+ } else if (mode == TypeBuilder::getEnumConstantValue(TypeBuilder::DOM::InspectMode::ShowLayoutEditor)) {
+ searchMode = ShowLayoutEditor;
} else {
*errorString = "Unknown mode \"" + mode + "\" was provided.";
return;
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.h ('k') | Source/core/inspector/InspectorHighlight.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698