Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: Source/devtools/front_end/components/InspectElementModeController.js

Issue 1311783003: Devtools[LayoutEditor]: Rework layout-editor workflow (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@resize
Patch Set: Small improvements Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/InspectElementModeController.js
diff --git a/Source/devtools/front_end/components/InspectElementModeController.js b/Source/devtools/front_end/components/InspectElementModeController.js
index f0d3d766f48c230228e1e2a97e7d292a5de5b99e..344a04695741074ec5a18152808592ea78037819 100644
--- a/Source/devtools/front_end/components/InspectElementModeController.js
+++ b/Source/devtools/front_end/components/InspectElementModeController.js
@@ -55,7 +55,7 @@ WebInspector.InspectElementModeController.prototype = {
{
// When DevTools are opening in the inspect element mode, the first target comes in
// much later than the InspectorFrontendAPI.enterInspectElementMode event.
- if (!this.enabled())
+ if (!this.started())
return;
var domModel = WebInspector.DOMModel.fromTarget(target);
domModel.setInspectMode(WebInspector.moduleSetting("showUAShadowDOM").get() ? DOMAgent.InspectMode.SearchForUAShadowDOM : DOMAgent.InspectMode.SearchForNode);
@@ -72,25 +72,39 @@ WebInspector.InspectElementModeController.prototype = {
/**
* @return {boolean}
*/
- enabled: function()
+ started: function()
{
return this._toggleSearchButton.toggled();
},
- disable: function()
+ stop: function()
{
- if (this.enabled())
+ if (this.started())
this._toggleSearch();
},
+ disable: function()
+ {
+ this.stop();
+ this._toggleSearchButton.setEnabled(false);
+ },
+
+ enable: function()
+ {
+ this._toggleSearchButton.setEnabled(true);
+ },
+
_toggleSearch: function()
{
- var enabled = !this.enabled();
- this._toggleSearchButton.setToggled(enabled);
+ if (!this._toggleSearchButton.enabled())
+ return;
+
+ var shouldEnable = !this.started();
+ this._toggleSearchButton.setToggled(shouldEnable);
for (var domModel of WebInspector.DOMModel.instances()) {
var mode;
- if (!enabled)
+ if (!shouldEnable)
mode = DOMAgent.InspectMode.None;
else if (WebInspector.moduleSetting("showUAShadowDOM").get())
mode = DOMAgent.InspectMode.SearchForUAShadowDOM;

Powered by Google App Engine
This is Rietveld 408576698