Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1563)

Unified Diff: Source/devtools/front_end/sdk/DOMModel.js

Issue 1311783003: Devtools[LayoutEditor]: Rework layout-editor workflow (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@resize
Patch Set: Rebase on dgozman changes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/DOMModel.js
diff --git a/Source/devtools/front_end/sdk/DOMModel.js b/Source/devtools/front_end/sdk/DOMModel.js
index aec85a2d3bb4339c0397570197acb0f23340e69b..a5053eccd9c8a02d744a803c8415d4622f7918e7 100644
--- a/Source/devtools/front_end/sdk/DOMModel.js
+++ b/Source/devtools/front_end/sdk/DOMModel.js
@@ -1747,10 +1747,10 @@ WebInspector.DOMModel.prototype = {
/**
* @param {boolean} enabled
- * @param {boolean} inspectUAShadowDOM
+ * @param {?string} mode
* @param {function(?Protocol.Error)=} callback
*/
- setInspectModeEnabled: function(enabled, inspectUAShadowDOM, callback)
+ setInspectModeEnabled: function(enabled, mode, callback)
{
/**
* @this {WebInspector.DOMModel}
@@ -1758,7 +1758,7 @@ WebInspector.DOMModel.prototype = {
function onDocumentAvailable()
{
this.dispatchEventToListeners(WebInspector.DOMModel.Events.InspectModeWillBeToggled, enabled);
- this._highlighter.setInspectModeEnabled(enabled, inspectUAShadowDOM, this._buildHighlightConfig(), callback);
+ this._highlighter.setInspectModeEnabled(enabled, mode, this._buildHighlightConfig(), callback);
}
this.requestDocument(onDocumentAvailable.bind(this));
},
@@ -2102,11 +2102,11 @@ WebInspector.DOMNodeHighlighter.prototype = {
/**
* @param {boolean} enabled
- * @param {boolean} inspectUAShadowDOM
+ * @param {?string} mode
* @param {!DOMAgent.HighlightConfig} config
* @param {function(?Protocol.Error)=} callback
*/
- setInspectModeEnabled: function(enabled, inspectUAShadowDOM, config, callback) {},
+ setInspectModeEnabled: function(enabled, mode, config, callback) {},
/**
* @param {!PageAgent.FrameId} frameId
@@ -2143,13 +2143,13 @@ WebInspector.DefaultDOMNodeHighlighter.prototype = {
/**
* @override
* @param {boolean} enabled
- * @param {boolean} inspectUAShadowDOM
+ * @param {?string} mode
dgozman 2015/08/28 23:44:11 string|undefined
sergeyv 2015/09/02 00:40:58 Not actual anymore
* @param {!DOMAgent.HighlightConfig} config
* @param {function(?Protocol.Error)=} callback
*/
- setInspectModeEnabled: function(enabled, inspectUAShadowDOM, config, callback)
+ setInspectModeEnabled: function(enabled, mode, config, callback)
{
- this._agent.setInspectModeEnabled(enabled, inspectUAShadowDOM, config, callback);
+ this._agent.setInspectModeEnabled(enabled, mode || undefined, config, callback);
},
/**

Powered by Google App Engine
This is Rietveld 408576698