Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: Source/core/inspector/InspectorDOMAgent.h

Issue 1311783003: Devtools[LayoutEditor]: Rework layout-editor workflow (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@resize
Patch Set: Rebase on dgozman changes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorDOMAgent.h
diff --git a/Source/core/inspector/InspectorDOMAgent.h b/Source/core/inspector/InspectorDOMAgent.h
index 514e2046e8f3e0cdb8c68e14a426372e5149224b..26d5e83e8c9d53d237329a044fcdf4acd9f56caa 100644
--- a/Source/core/inspector/InspectorDOMAgent.h
+++ b/Source/core/inspector/InspectorDOMAgent.h
@@ -94,6 +94,7 @@ public:
virtual void hideHighlight() { }
virtual void highlightNode(Node*, Node* eventTarget, const InspectorHighlightConfig&, bool omitTooltip) { }
virtual void highlightQuad(PassOwnPtr<FloatQuad>, const InspectorHighlightConfig&) { }
+ virtual void showLayoutEditorForNode(Node*, const InspectorHighlightConfig&) { }
};
static PassOwnPtrWillBeRawPtr<InspectorDOMAgent> create(InspectorPageAgent* pageAgent, InjectedScriptManager* injectedScriptManager, Client* client)
@@ -132,7 +133,7 @@ public:
void discardSearchResults(ErrorString*, const String& searchId) override;
void resolveNode(ErrorString*, int nodeId, const String* objectGroup, RefPtr<TypeBuilder::Runtime::RemoteObject>& result) override;
void getAttributes(ErrorString*, int nodeId, RefPtr<TypeBuilder::Array<String>>& result) override;
- void setInspectModeEnabled(ErrorString*, bool enabled, const bool* inspectUAShadowDOM, const RefPtr<JSONObject>* highlightConfig) override;
+ void setInspectModeEnabled(ErrorString*, bool enabled, const String* mode, const RefPtr<JSONObject>* highlightConfig) override;
void requestNode(ErrorString*, const String& objectId, int* nodeId) override;
void pushNodeByPathToFrontend(ErrorString*, const String& path, int* nodeId) override;
void pushNodesByBackendIdsToFrontend(ErrorString*, const RefPtr<JSONArray>& nodeIds, RefPtr<TypeBuilder::Array<int>>&) override;
@@ -191,6 +192,8 @@ public:
InspectorHistory* history() { return m_history.get(); }
+ void resumeSearchingForNode(Node*);
+
// We represent embedded doms as a part of the same hierarchy. Hence we treat children of frame owners differently.
// We also skip whitespace text nodes conditionally. Following methods encapsulate these specifics.
static Node* innerFirstChild(Node*);
@@ -205,7 +208,7 @@ public:
Document* assertDocument(ErrorString*, int nodeId);
private:
- enum SearchMode { NotSearching, SearchingForNormal, SearchingForUAShadow };
+ enum SearchMode { NotSearching, SearchingForNormal, SearchingForUAShadow, SearchingInLayoutEditor };
InspectorDOMAgent(InspectorPageAgent*, InjectedScriptManager*, Client*);
@@ -246,6 +249,7 @@ private:
bool pushDocumentUponHandlelessOperation(ErrorString*);
RawPtrWillBeMember<InspectorRevalidateDOMTask> revalidateTask();
+ bool shouldHandleInputEvents();
RawPtrWillBeMember<InspectorPageAgent> m_pageAgent;
RawPtrWillBeMember<InjectedScriptManager> m_injectedScriptManager;
@@ -271,6 +275,7 @@ private:
OwnPtrWillBeMember<DOMEditor> m_domEditor;
bool m_suppressAttributeModifiedEvent;
int m_backendNodeIdToInspect;
+ bool m_layoutEditorEnabled;
};
« no previous file with comments | « no previous file | Source/core/inspector/InspectorDOMAgent.cpp » ('j') | Source/core/inspector/InspectorDOMAgent.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698