Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 1311713004: Add UseCounters for usage of -webkit-text (Closed)

Created:
5 years, 3 months ago by Timothy Loh
Modified:
5 years, 3 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add UseCounters for usage of -webkit-text We currently support -webkit-text as a value in clip properties, background-clip, -webkit-background-clip and -webkit-mask-clip, as well as in color properties (only when in quirks mode). I suspect usage is extremely rare in both cases so this patch adds counters for these. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201363

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 chunks +8 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Timothy Loh
5 years, 3 months ago (2015-08-27 07:30:38 UTC) #2
alancutter (OOO until 2018)
lgtm
5 years, 3 months ago (2015-08-27 07:35:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311713004/1
5 years, 3 months ago (2015-08-27 07:42:37 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 3 months ago (2015-08-27 09:53:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311713004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311713004/20001
5 years, 3 months ago (2015-08-28 02:00:07 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 03:21:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201363

Powered by Google App Engine
This is Rietveld 408576698