Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1311703003: Added Tor

Created:
5 years, 4 months ago by deepankar-tyagi
Modified:
5 years, 3 months ago
Reviewers:
binji, Sam Clegg
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Added Tor This pull request is in continuation to the following issue https://codereview.chromium.org/1289343005/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -21 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
A ports/libevent/README.nacl View 1 chunk +48 lines, -0 lines 0 comments Download
A ports/libevent/build.sh View 1 chunk +18 lines, -0 lines 0 comments Download
A ports/libevent/nacl.patch View 1 chunk +64 lines, -0 lines 0 comments Download
A ports/libevent/pkg_info View 1 chunk +7 lines, -0 lines 0 comments Download
A ports/tor/README.nacl View 1 chunk +64 lines, -0 lines 0 comments Download
A ports/tor/background.js View 1 chunk +22 lines, -0 lines 0 comments Download
A ports/tor/build.sh View 1 chunk +45 lines, -0 lines 0 comments Download
A ports/tor/index.html View 1 chunk +46 lines, -0 lines 0 comments Download
A ports/tor/krotor_128.png View Binary file 0 comments Download
A ports/tor/krotor_16.png View Binary file 0 comments Download
A ports/tor/krotor_48.png View Binary file 0 comments Download
A + ports/tor/manifest.json View 2 chunks +21 lines, -21 lines 0 comments Download
A ports/tor/nacl.patch View 1 chunk +103 lines, -0 lines 0 comments Download
A ports/tor/pkg_info View 1 chunk +7 lines, -0 lines 0 comments Download
A ports/tor/tor.js View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
deepankar-tyagi
5 years, 4 months ago (2015-08-25 19:57:24 UTC) #2
binji
On 2015/08/25 at 19:57:24, deepankar7tyagi wrote: > Please remove this review and update the previous ...
5 years, 3 months ago (2015-08-28 16:34:11 UTC) #3
deepankar-tyagi
On 2015/08/28 16:34:11, binji wrote: > On 2015/08/25 at 19:57:24, deepankar7tyagi wrote: > > > ...
5 years, 3 months ago (2015-08-28 17:03:00 UTC) #4
binji
5 years, 3 months ago (2015-08-28 17:20:16 UTC) #5
On 2015/08/28 at 17:03:00, deepankar7tyagi wrote:
> On 2015/08/28 16:34:11, binji wrote:
> > On 2015/08/25 at 19:57:24, deepankar7tyagi wrote:
> > > 
> > 
> > Please remove this review and update the previous one instead.
> > https://codereview.chromium.org/1289343005/
> 
> issue : 1289343005 is on pepper_44
> this one is on master.
> 
> on pepper_44
> As per the comments by Mr. Sam Clegg 
> (https://codereview.chromium.org/1289343005/#msg6)
> 
> #1 " You only need NACL_CLI_MAIN_LIB.. that other are all included in that."
> 
> however this is not the case, builds are failing without
> -lppapi_simple -lnacl_io -lppapi -l${NACL_CXX_LIB}"
> 
> #2 ports/glibc-compat/src/writev.c:4: 
> "Have you don't a sync recently?  I think these functions were already added a
> few weeks ago in this change:
> https://codereview.chromium.org/1260083004"
> 
> These changes are available in master branch and not on pepper_44

Ah, I didn't notice that. Yes, we usually only make changes on master and the
merge to the branches if necessary.

> 
> Due to these two issue I added these ports to master branch and 
> git-cl created separate issues
> 
> Can one force git-cl to associate an issue with it ?
> (with git-cl issue ?)

You can using git cl issue, but I don't believe you can change the base url. So
you're right, these will need to be different CLs. In that case, please close
the other one.

Powered by Google App Engine
This is Rietveld 408576698