Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: Source/devtools/front_end/network/NetworkLogView.js

Issue 1311693004: [DevTools] UI for blocked URLs. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: typo Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/network/NetworkLogView.js
diff --git a/Source/devtools/front_end/network/NetworkLogView.js b/Source/devtools/front_end/network/NetworkLogView.js
index dd941dc402f2ceb52e11db7ae6f45b6f6d9c9352..2fc70f4d8f138115416c910acc16b391c0b75966 100644
--- a/Source/devtools/front_end/network/NetworkLogView.js
+++ b/Source/devtools/front_end/network/NetworkLogView.js
@@ -1299,10 +1299,24 @@ WebInspector.NetworkLogView.prototype = {
contextMenu.appendItem(WebInspector.UIString.capitalize("Clear ^browser ^cache"), this._clearBrowserCache.bind(this));
contextMenu.appendItem(WebInspector.UIString.capitalize("Clear ^browser ^cookies"), this._clearBrowserCookies.bind(this));
- var manager = WebInspector.multitargetNetworkManager;
- if (Runtime.experiments.isEnabled("blockedURLs") && request && !manager.blockedURLs().has(request.url)) {
+ var blockedSetting = WebInspector.moduleSetting("blockedURLs");
+ if (Runtime.experiments.isEnabled("blockedURLs") && request) {
contextMenu.appendSeparator();
- contextMenu.appendItem(WebInspector.UIString.capitalize("Block ^request URL"), manager.toggleURLBlocked.bind(manager, request.url));
+
+ var urlWithoutScheme = request.parsedURL.urlWithoutScheme();
+ if (urlWithoutScheme && blockedSetting.get().indexOf(urlWithoutScheme) === -1)
+ contextMenu.appendItem(WebInspector.UIString.capitalize("Block ^request URL"), addBlockedURL.bind(null, urlWithoutScheme));
+
+ var domain = request.parsedURL.domain();
+ if (domain && blockedSetting.get().indexOf(domain) === -1)
+ contextMenu.appendItem(WebInspector.UIString.capitalize("Block ^request ^domain"), addBlockedURL.bind(null, domain));
+
+ function addBlockedURL(url)
+ {
+ var list = blockedSetting.get();
+ list.push(url);
+ blockedSetting.set(list);
+ }
}
if (request && request.resourceType() === WebInspector.resourceTypes.XHR) {

Powered by Google App Engine
This is Rietveld 408576698